[DRAFT] explorer: [android] open directory #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whereswaldon
reviewed
Jun 2, 2025
There was a problem hiding this comment.
Thanks for providing this reference implementation @inkeliz! I noted a lifecycle issue with global JNI references, but your email to the list implies that you have other concerns with the implementation. Would you mind listing what (in your mind) needs to be improved here in order for this code to be ready for production use? I lack your expertise in Android APIs.
Comment on lines
+39
to
+40
| f.libObject = jni.NewGlobalRef(env, obj) | ||
| f.libClass = jni.Class(jni.NewGlobalRef(env, jni.Object(class))) |
There was a problem hiding this comment.
Where and how are these global references cleaned up? I don't see any mechanism to do that, and I don't think the JVM is able to do it automatically.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.