fix: Safer chown call in runner scripts for custom AMIs - #4654
Merged
Conversation
Contributor
Author
|
There are a few other places that use the current directory ( |
npalm
self-requested a review
July 2, 2025 21:07
npalm
approved these changes
Jul 9, 2025
npalm
pushed a commit
that referenced
this pull request
Jul 10, 2025
🤖 I have created a release *beep* *boop* --- ## [6.6.1](v6.6.0...v6.6.1) (2025-07-09) ### Bug Fixes * Safer chown call in runner scripts for custom AMIs ([#4654](#4654)) ([0114816](0114816)) @nmodi1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
…unners#4654) Updated the install-runner and start-runner scripts to call `chown` on explicit path instead of just using the current directory. The current script will work for most users, however, this change will make it more safer and avoid risk of unintended changes. For example, if the `cd /opt/actions-runner` call in the template file (`images/start-runner.sh`) is missed, the script will change owner of the root directory (`/`) instead. --------- Co-authored-by: Niek Palm <npalm@users.noreply.github.com>
LudovicTOURMAN
pushed a commit
to doctolib-lab/terraform-aws-github-runner
that referenced
this pull request
Apr 7, 2026
🤖 I have created a release *beep* *boop* --- ## [6.6.1](github-aws-runners/terraform-aws-github-runner@v6.6.0...v6.6.1) (2025-07-09) ### Bug Fixes * Safer chown call in runner scripts for custom AMIs ([github-aws-runners#4654](github-aws-runners#4654)) ([0114816](github-aws-runners@0114816)) @nmodi1 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: runners-releaser[bot] <194412594+runners-releaser[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the install-runner and start-runner scripts to call
chownon explicit path instead of just using the current directory.The current script will work for most users, however, this change will make it more safer and avoid risk of unintended changes. For example, if the
cd /opt/actions-runnercall in the template file (images/start-runner.sh) is missed, the script will change owner of the root directory (/) instead.