-
Notifications
You must be signed in to change notification settings - Fork 9
Add support for managing cluster workload groups #113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR adds support for Workload Groups management to the Kusto Schema Tools, extending the existing cluster configuration orchestration capabilities. The implementation handles creation, updates, and deletion of workload groups alongside the existing capacity policy management.
- Addition of workload groups support to cluster configuration management
- Implementation of workload group comparison and change detection logic
- Enhanced test coverage for workload group operations and edge cases
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 4 comments.
Show a summary per file
File | Description |
---|---|
README.md | Updated documentation to include workload groups as a supported feature |
KustoClusterHandler.cs | Added workload groups loading from live clusters via .show workload_groups command |
ClusterDeletions.cs | New model to track workload groups marked for deletion |
Cluster.cs | Added Deletions property to support workload group deletion tracking |
DeletionChange.cs | Enhanced to support custom markdown for better deletion reporting |
ClusterChanges.cs | Major refactoring to handle workload group changes with creation, update, and deletion logic |
KustoClusterHandlerTests.cs | Comprehensive test coverage for workload group loading scenarios |
ClusterChangesTest.cs | Extensive test suite covering workload group change detection |
Co-authored-by: Copilot <[email protected]>
Co-authored-by: Copilot <[email protected]>
This PR updates the
KustoClusterOrchestrator
helper classes to support managing workload groups -- creation, modification, and deletion.https://github.com/github/data/issues/9010
This PR is a follow-up to #111, #110, #106
Changes
KustoSchemaTools/Changes/ClusterChanges.cs
HandleCapacityPolicyChanges
to improve readabilityHandleWorkloadGroupChanges
to process workload group deletions, creations, and updatesdeletions
section of the YAML fileKustoSchemaTools/Parser/KustoClusterHandler.cs