Fix workload group markdown formatting - #114
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR fixes formatting issues in the markdown output for workload group changes in the KustoSchemaTools project. The changes improve consistency in heading levels and fix the display of list properties.
- Updates the heading format for deleted workload groups from H4 to H3 for consistency
- Adds proper handling for enumerable properties in markdown formatting by converting them to bracketed string representations
joopica
approved these changes
Jul 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Minor changes to the markdown for workload groups:
WorkloadGroup.RequestRateLimitPoliciesis an unordered list, but it was being compared as an ordered list which was giving false positives and had poor markdown formatting. This PR changes the property toPolicyList<T>, that inherits fromList<T>and overrides Equals and ToString to perform order-independent comparison.