Skip to content

A15-4-4: Support deviation on the function declaration #816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 31, 2025
Merged

A15-4-4: Support deviation on the function declaration #816

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
0673c77
A15-4-4: Support deviation on the function declaration
lcartey Nov 29, 2024
5e753af
Add change note
lcartey Dec 10, 2024
22f95ad
Add deviation file
lcartey Jan 29, 2025
7986b3b
Merge branch 'main' into lcartey/a15-4-4-deviation
lcartey Jan 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions change_notes/2024-12-10-a15-4-4-deviations.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
- `A15-4-4` - `MissingNoExcept.ql`:
- Enable deviations on either declarations or definitions.
2 changes: 1 addition & 1 deletion cpp/autosar/src/rules/A15-4-4/MissingNoExcept.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ predicate mayCallThrowingFunctions(Function f) {

from Function f
where
not isExcluded(f, Exceptions1Package::missingNoExceptQuery()) and
not isExcluded(f.getADeclarationEntry(), Exceptions1Package::missingNoExceptQuery()) and
// No thrown exceptions
not exists(getAFunctionThrownType(f, _)) and
// But not marked noexcept(true)
Expand Down
11 changes: 11 additions & 0 deletions cpp/autosar/test/rules/A15-4-4/coding-standards.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,11 @@
<?xml version="1.0" ?>
<codingstandards>
<!--GENERATED: DO NOT MODIFY. Changes should be made to coding-standards.yml instead.-->
<deviations>
<deviations-entry>
<rule-id>A15-4-4</rule-id>
<justification>Suppress entry.</justification>
<code-identifier>a-15-4-4-deviation</code-identifier>
</deviations-entry>
</deviations>
</codingstandards>
10 changes: 9 additions & 1 deletion cpp/autosar/test/rules/A15-4-4/test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,4 +56,12 @@ std::string test_fp_reported_in_424(
s3.append(s1.c_str(), s1.size());
s3.append(s2.c_str(), s2.size());
return s3;
}
}

void test_no_except_deviated_decl(); // a-15-4-4-deviation

void test_no_except_deviated_decl() {}

void test_no_except_deviated_defn();

void test_no_except_deviated_defn() {} // a-15-4-4-deviation
Loading