Skip to content

CERT: Add query tags for "Risk Assessment" properties #896

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
May 14, 2025
Merged

CERT: Add query tags for "Risk Assessment" properties #896

Show file tree
Hide file tree
Changes from 7 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
a1f45ff
Add a script to lift CERT risk assessment tags from help files
lcartey May 1, 2025
242744c
Add additional CERT risk assessment tags
lcartey May 1, 2025
cb66b8c
Update script to check for CERT risk assessment tags
lcartey May 1, 2025
0b27939
Add missing header markers to markdown files
lcartey May 1, 2025
be29857
Add risk assessment tags to CERT queries
lcartey May 1, 2025
5441654
Add query suites for levels 1 to 3.
lcartey May 2, 2025
df44da0
Add change note
lcartey May 2, 2025
9e24b41
Remove spurious recommendation tag
lcartey May 5, 2025
44617e8
Update expected results for query file changes
lcartey May 5, 2025
f7c77cb
Update rule package schema for new allowed tags
lcartey May 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 12 additions & 0 deletions c/cert/src/codeql-suites/cert-c-l1.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- description: CERT C 2016 Level 1 Rules (Priority 12 - Priority 27)
- qlpack: codeql/cert-c-coding-standards
- include:
kind:
- problem
- path-problem
- external/cert/obligation/rule
tags contain:
- external/cert/level/l1
- exclude:
tags contain:
- external/cert/default-disabled
12 changes: 12 additions & 0 deletions c/cert/src/codeql-suites/cert-c-l2.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- description: CERT C 2016 Level 2 Rules (Priority 6 - Priority 9)
- qlpack: codeql/cert-c-coding-standards
- include:
kind:
- problem
- path-problem
- external/cert/obligation/rule
tags contain:
- external/cert/level/l2
- exclude:
tags contain:
- external/cert/default-disabled
12 changes: 12 additions & 0 deletions c/cert/src/codeql-suites/cert-c-l3.qls
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
- description: CERT C 2016 Level 3 Rules (Priority 1 - Priority 4)
- qlpack: codeql/cert-c-coding-standards
- include:
kind:
- problem
- path-problem
- external/cert/obligation/rule
tags contain:
- external/cert/level/l3
- exclude:
tags contain:
- external/cert/default-disabled
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR30-C/DoNotFormOutOfBoundsPointersOrArraySubscripts.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/arr30-c
* correctness
* security
* external/cert/severity/high
* external/cert/likelihood/likely
* external/cert/remediation-cost/high
* external/cert/priority/p9
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR32-C/VariableLengthArraySizeNotInValidRange.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/arr32-c
* correctness
* security
* external/cert/severity/high
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p6
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR36-C/DoNotRelatePointersThatDoNotReferToTheSameArray.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity warning
* @tags external/cert/id/arr36-c
* correctness
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/medium
* external/cert/priority/p8
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR36-C/DoNotSubtractPointersThatDoNotReferToTheSameArray.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity warning
* @tags external/cert/id/arr36-c
* correctness
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/medium
* external/cert/priority/p8
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR37-C/DoNotUsePointerArithmeticOnNonArrayObjectPointers.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity error
* @tags external/cert/id/arr37-c
* correctness
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/medium
* external/cert/priority/p8
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR38-C/LibraryFunctionArgumentOutOfBounds.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/arr38-c
* correctness
* security
* external/cert/severity/high
* external/cert/likelihood/likely
* external/cert/remediation-cost/medium
* external/cert/priority/p18
* external/cert/level/l1
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/ARR39-C/DoNotAddOrSubtractAScaledIntegerToAPointer.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity error
* @tags external/cert/id/arr39-c
* correctness
* external/cert/severity/high
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p6
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON30-C/CleanUpThreadSpecificStorage.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con30-c
* correctness
* concurrency
* external/cert/severity/medium
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/medium
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON31-C/DoNotAllowAMutexToGoOutOfScopeWhileLocked.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con31-c
* correctness
* concurrency
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON31-C/DoNotDestroyAMutexWhileItIsLocked.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @tags external/cert/id/con31-c
* correctness
* concurrency
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON32-C/PreventDataRacesWithMultipleThreads.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con32-c
* correctness
* concurrency
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/medium
* external/cert/priority/p8
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON33-C/RaceConditionsWhenUsingLibraryFunctions.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @tags external/cert/id/con33-c
* correctness
* concurrency
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
6 changes: 6 additions & 0 deletions c/cert/src/rules/CON34-C/AppropriateThreadObjectStorageDurations.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,12 @@
* @tags external/cert/id/con34-c
* correctness
* concurrency
* external/cert/recommendation/con34-c
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
6 changes: 6 additions & 0 deletions c/cert/src/rules/CON34-C/ThreadObjectStorageDurationsNotInitialized.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,12 @@
* external/cert/audit
* correctness
* concurrency
* external/cert/recommendation/con34-c
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON35-C/DeadlockByLockingInPredefinedOrder.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con35-c
* correctness
* concurrency
* external/cert/severity/low
* external/cert/likelihood/probable
* external/cert/remediation-cost/medium
* external/cert/priority/p4
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON36-C/WrapFunctionsThatCanSpuriouslyWakeUpInLoop.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con36-c
* correctness
* concurrency
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/medium
* external/cert/priority/p2
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON37-C/DoNotCallSignalInMultithreadedProgram.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con37-c
* correctness
* concurrency
* external/cert/severity/low
* external/cert/likelihood/probable
* external/cert/remediation-cost/low
* external/cert/priority/p6
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON38-C/PreserveSafetyWhenUsingConditionVariables.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con38-c
* correctness
* concurrency
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/medium
* external/cert/priority/p2
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON39-C/ThreadWasPreviouslyJoinedOrDetached.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con39-c
* correctness
* concurrency
* external/cert/severity/low
* external/cert/likelihood/likely
* external/cert/remediation-cost/medium
* external/cert/priority/p6
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON40-C/AtomicVariableTwiceInExpression.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con40-c
* correctness
* concurrency
* external/cert/severity/medium
* external/cert/likelihood/probable
* external/cert/remediation-cost/medium
* external/cert/priority/p8
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/CON41-C/WrapFunctionsThatCanFailSpuriouslyInLoop.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* @tags external/cert/id/con41-c
* correctness
* concurrency
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/medium
* external/cert/priority/p2
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL30-C/AppropriateStorageDurationsFunctionReturn.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity error
* @tags external/cert/id/dcl30-c
* correctness
* external/cert/severity/high
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p6
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL30-C/AppropriateStorageDurationsStackAdressEscape.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity error
* @tags external/cert/id/dcl30-c
* correctness
* external/cert/severity/high
* external/cert/likelihood/probable
* external/cert/remediation-cost/high
* external/cert/priority/p6
* external/cert/level/l2
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL31-C/DeclareIdentifiersBeforeUsingThem.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @tags external/cert/id/dcl31-c
* correctness
* readability
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/low
* external/cert/priority/p3
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL37-C/DoNotDeclareOrDefineAReservedIdentifier.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* correctness
* maintainability
* readability
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/low
* external/cert/priority/p3
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL38-C/DeclaringAFlexibleArrayMember.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,11 @@
* correctness
* maintainability
* readability
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/low
* external/cert/priority/p3
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
2 changes: 1 addition & 1 deletion c/cert/src/rules/DCL39-C/InformationLeakageAcrossTrustBoundariesC.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ In addition, this solution assumes that there are no integer padding bits in an

From this situation, it can be seen that special care must be taken because no solution to the bit-field padding issue will be 100% portable.

Risk Assessment
## Risk Assessment

Padding units might contain sensitive data because the C Standard allows any padding to take [unspecified values](https://wiki.sei.cmu.edu/confluence/display/c/BB.+Definitions#BB.Definitions-unspecifiedvalue). A pointer to such a structure could be passed to other functions, causing information leakage.

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL39-C/InformationLeakageAcrossTrustBoundariesC.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,11 @@
* @problem.severity error
* @tags external/cert/id/dcl39-c
* security
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/high
* external/cert/priority/p1
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
5 changes: 5 additions & 0 deletions c/cert/src/rules/DCL40-C/ExcessLengthNamesIdentifiersNotDistinct.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@
* correctness
* maintainability
* readability
* external/cert/severity/low
* external/cert/likelihood/unlikely
* external/cert/remediation-cost/medium
* external/cert/priority/p2
* external/cert/level/l3
* external/cert/obligation/rule
*/

Expand Down
Loading
Loading