JS: removed unnecessary getALocalSource from ArrayCallBackDataFlowStep

Napalys · Napalys · commit 64c45debdb4c · 2024-11-20T14:57:00.000+01:00
diff --git a/javascript/ql/lib/semmle/javascript/Arrays.qll b/javascript/ql/lib/semmle/javascript/Arrays.qll
@@ -492,7 +492,7 @@ private module ArrayLibraries {
       exists(DataFlow::MethodCallNode call |
         call.getMethodName() = ["findLast", "find", "findLastIndex"] and
         prop = arrayLikeElement() and
-        obj = call.getReceiver().getALocalSource() and
+        obj = call.getReceiver() and
         element = call.getCallback(0).getParameter(0)
       )
     }

Original file line number	Diff line number	Diff line change
`@@ -492,7 +492,7 @@ private module ArrayLibraries {`
`492`	`492`	`exists(DataFlow::MethodCallNode call \|`
`493`	`493`	`call.getMethodName() = ["findLast", "find", "findLastIndex"] and`
`494`	`494`	`prop = arrayLikeElement() and`
`495`		`- obj = call.getReceiver().getALocalSource() and`
	`495`	`+ obj = call.getReceiver() and`
`496`	`496`	`element = call.getCallback(0).getParameter(0)`
`497`	`497`	`)`
`498`	`498`	`}`