-
Notifications
You must be signed in to change notification settings - Fork 64.5k
enhance(avoiding-duplication): secrets comparison accuracy #39062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR improves the accuracy of the secret comparison between reusable workflows and composite actions.
- Updated the table entry for secrets to reflect that secrets must be passed explicitly as named secrets for reusable workflows and as inputs for composite actions.
Comments suppressed due to low confidence (1)
content/actions/concepts/workflows-and-actions/avoiding-duplication.md:47
- [nitpick] Ensure that the updated language for secret handling remains consistent with the broader documentation style and guidelines for describing secret passing methods.
| Secrets must be passed as explicit named secrets | Secrets must be passed as inputs from the calling workflow |
How to review these changes 👓Thank you for your contribution. To review these changes, choose one of the following options: A Hubber will need to deploy your changes internally to review. Table of review linksNote: Please update the URL for your staging server or codespace. The table shows the files in the
Key: fpt: Free, Pro, Team; ghec: GitHub Enterprise Cloud; ghes: GitHub Enterprise Server 🤖 This comment is automatically generated. |
|
I'll look into this one, too! |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
A stale label has been added to this pull request because it has been open 30 days with no activity. If you think this pull request should remain open, please add a new comment. |
|
@Malix-Labs Someone from the Actions team is supposed to be looking into this and several other things, and I've poked them recently, so I'll let you know when I hear something. Sorry for the wait and thanks for being so patient. |
|
@Malix-Labs The Actions teams doesn't want to make this exact change. They're not sure things are working as intended and want to look into it internally, so they've rejected this PR. Sorry, I know that was a long wait to get an answer you don't want, but at least someone is looking at it. |
|
Well, something must at least be done because the docs are just incorrect wrong as they currently are (it has actually been sent to us from a big client that was confused by this) The sentence I wrote are for sure really not the best, but i'm sure the actions team could come up with a better fix instead! Can you notify them please, @Sharra-writes? |
|
@Malix-Labs I'll let them know. I am really sorry about this, and I wish they had given me more details or some sort of compromise, but I have to defer to their team on these issues regardless of whether I'm satisfied. |
Why:
The secret comparison between reusable workflows and composite actions was inaccurate
What's being changed (if available, include any code snippets, screenshots, or gifs):
Enhancing the accuracy of the secret comparison between reusable workflows and composite actions
Check off the following: