Skip to content

Adds help center URL fallback for disabled walkthroughs #4418

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

d13
Copy link
Member

@d13 d13 commented Jun 24, 2025

This brings back all the disabled Walkthrough actions for Cursor. Instead of trying to open the walkthrough, it will instead open a Help Center page.

@d13 d13 linked an issue Jul 17, 2025 that may be closed by this pull request
@d13 d13 force-pushed the feature/walkthroughs-url-fallback branch 2 times, most recently from 7e9370b to f39d358 Compare July 25, 2025 19:36
@d13 d13 force-pushed the feature/walkthroughs-url-fallback branch from f39d358 to 028bd42 Compare August 15, 2025 22:11
@d13 d13 marked this pull request as ready for review August 15, 2025 22:47
@d13 d13 requested review from Copilot and eamodio August 15, 2025 22:51
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds help center URL fallback functionality for disabled walkthroughs in Cursor. Instead of trying to open the walkthrough when it's not supported (specifically in Cursor), the system will redirect users to relevant Help Center pages.

Key changes include:

  • Refactoring walkthrough-related code to always instantiate the walkthrough service regardless of support status
  • Adding fallback URL mappings and telemetry tracking for when help center URLs are used instead of walkthroughs
  • Moving walkthrough context keys to a shared constants file for better organization

Reviewed Changes

Copilot reviewed 15 out of 15 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
src/webviews/home/protocol.ts Adds walkthrough state tracking to the home webview protocol
src/webviews/home/homeWebview.ts Refactors walkthrough progress handling to always provide state data
src/webviews/apps/home/components/onboarding.ts Enhances onboarding component with detailed walkthrough progress display
src/telemetry/walkthroughStateProvider.ts Moves type definitions and adds state getter method
src/plus/launchpad/launchpadIndicator.ts Removes conditional walkthrough support checks
src/plus/launchpad/launchpad.ts Removes conditional walkthrough support checks
src/plus/gk/subscriptionService.ts Removes conditional walkthrough support checks
src/container.ts Always instantiates walkthrough service
src/constants.walkthroughs.ts New file defining walkthrough context keys and progress steps
src/constants.ts Adds help center URLs for walkthrough fallbacks
src/constants.telemetry.ts Moves walkthrough context keys import and adds fallback URL tracking
src/constants.context.ts Updates walkthrough context keys import
src/commands/walkthroughs.ts Implements help center URL fallback logic with telemetry
src/commands/quickCommand.steps.ts Removes conditional walkthrough support check
docs/telemetry-events.md Documents new telemetry property for fallback URL usage

@d13 d13 force-pushed the feature/walkthroughs-url-fallback branch from 028bd42 to 6043a35 Compare August 15, 2025 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Walkthrough Links for Cursor
1 participant