AI feedback disposable provider #4480

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merged

sergeibbb merged 2 commits into 4449-feedback-on-changelog from 4449-feedback-provider

Jul 31, 2025

Member

sergeibbb commented Jul 8, 2025 •

edited

Loading

Description

This is a follow-up of #4449 and #4479

It wraps static ai-feedback related values to a disposable provided linked to the container.

Checklist

I have followed the guidelines in the Contributing document
My changes follow the coding style of this project
My changes build without any errors or warnings
My changes have been formatted and linted
My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

sergeibbb requested a review from eamodio

July 8, 2025 19:36

Member Author

sergeibbb commented Jul 8, 2025 •

edited

Loading

There are 2 pull requests.

The first one is the implementation for Changelogs in a similar manner how it's been done for markdown previews.
The second one (this one) is a follow-up. It wraps static values to a disposable provided linked to the container.

Please let me know if you think that creating such provider is unnecessary or if you suggest it should be improved.

sergeibbb self-assigned this

sergeibbb linked an issue

that may be closed by this pull request

Capture sentiment feedback about AI feature effectiveness #4449

Closed

4 tasks

sergeibbb mentioned this pull request

Adds AI feedback support for changelog markdown editors #4479

Merged

7 tasks

sergeibbb force-pushed the 4449-feedback-on-changelog branch from 4437459 to 8b7c748 Compare

July 9, 2025 13:48

sergeibbb force-pushed the 4449-feedback-provider branch from 5fc533a to 51f82c3 Compare

July 9, 2025 13:48

sergeibbb marked this pull request as ready for review

July 9, 2025 14:12

sergeibbb requested a review from axosoft-ramint

July 9, 2025 14:15

sergeibbb force-pushed the 4449-feedback-on-changelog branch from 8b7c748 to 5233993 Compare

July 9, 2025 14:20

sergeibbb added a commit that referenced this pull request


          Refactors AI feedback context handling for changelog docs

61a994c

Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4480)

sergeibbb force-pushed the 4449-feedback-provider branch from 51f82c3 to e815a8e Compare

July 9, 2025 14:20

sergeibbb added a commit that referenced this pull request


          Moves AI feedback URI state handling to provider

e815a8e

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

sergeibbb added this to the 17.4 milestone

sergeibbb force-pushed the 4449-feedback-on-changelog branch from 5233993 to 28c7ed5 Compare

July 14, 2025 09:20

sergeibbb force-pushed the 4449-feedback-provider branch from e815a8e to 1f08c2d Compare

July 14, 2025 09:21

sergeibbb added a commit that referenced this pull request


          Refactors AI feedback context handling for changelog docs

358a7ba

Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4480)

sergeibbb added a commit that referenced this pull request


          Moves AI feedback URI state handling to provider

1f08c2d

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

sergeibbb added a commit that referenced this pull request


          Moves AI feedback URI state handling to provider

f851fe3

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

sergeibbb force-pushed the 4449-feedback-provider branch from 1f08c2d to f851fe3 Compare

July 14, 2025 14:07

axosoft-ramint reviewed

View reviewed changes

Contributor

axosoft-ramint left a comment •

edited

Loading

I'm having a hard time parsing the need for this between all of the linked issues and PRs, nor do I know how to test it, so I will defer to @eamodio 's review on this one, unless you can give me a full rundown/explanation as someone who hasn't been involved with this work @sergeibbb .

Member Author

sergeibbb commented Jul 15, 2025

I just thought that since the implementation is stateful it might be worth to attach it to the container as a stateful class.
@axosoft-ramint @ericf-axosoft

sergeibbb added a commit that referenced this pull request


          Refactors AI feedback context handling for changelog docs

138e394

Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4480)

sergeibbb added a commit that referenced this pull request


          Moves AI feedback URI state handling to provider

8549cda

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

sergeibbb force-pushed the 4449-feedback-on-changelog branch from 28c7ed5 to 60b3f8f Compare

July 28, 2025 16:39

sergeibbb added a commit that referenced this pull request


          Refactors AI feedback context handling for changelog docs

5208cff

Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4480)

sergeibbb added a commit that referenced this pull request


          Moves AI feedback URI state handling to provider

b98dc49

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

sergeibbb force-pushed the 4449-feedback-provider branch from f851fe3 to b98dc49 Compare

July 28, 2025 16:41

sergeibbb force-pushed the 4449-feedback-on-changelog branch from 60b3f8f to 91f9b4a Compare

July 28, 2025 17:15


          Refactors AI feedback context handling for changelog docs

5b42428

Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4480)


          Moves AI feedback URI state handling to provider

9cf1770

Consolidates storage and context updates for AI feedback responses
from the command layer into the provider, improving separation of
concerns and maintainability. Ensures feedback state is managed
centrally, reducing duplication and potential for inconsistencies.
(#4449, #4480)

sergeibbb force-pushed the 4449-feedback-provider branch from b98dc49 to 9cf1770 Compare

July 28, 2025 17:16

sergeibbb mentioned this pull request

Opens summary before AI result #4489

Merged

7 tasks

sergeibbb merged commit eee474b into 4449-feedback-on-changelog

1 check passed

sergeibbb added a commit that referenced this pull request


          Refactors AI feedback context handling for changelog docs

ff0c307

Centralizes management of AI feedback context and changelog document
URIs
into a dedicated provider, improving modularity and cleanup. Updates
relevant usages to access changelog feedback context through the new
provider, removing redundant context management logic from command
files.

Simplifies resource cleanup on document close and ensures consistent
context availability for AI-related features.
(#4449, #4480)

sergeibbb deleted the 4449-feedback-provider branch

July 31, 2025 11:46

sergeibbb restored the 4449-feedback-provider branch

July 31, 2025 11:46

Member Author

sergeibbb commented Jul 31, 2025

closed by mistake. reopened as #4518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet