[debt] Graph: consolidate state management and improve computed state #4482
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- moves graph theme from GraphAppState to graph wrapper - reduces JS-based color computing - removes computing colors of CSS custom properties - renames components for clarity
There was a problem hiding this comment.
Pull Request Overview
This PR centralizes graph-related state into a single provider, extends the app host to accept custom providers, and offloads color computations into a lightweight wrapper using CSS color-mix().
- Migrate
GraphAppStateinto a unifiedGraphStateProviderwith debounced context updates. - Update
GlAppHostto support specializedStateProvidertypes. - Refactor graph theming into
gl-graph-wrapper, replacing JS color math with CSS-based mixing.
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/webviews/plus/graph/protocol.ts | Dropped theming from the shared protocol and simplified callback. |
| src/webviews/apps/shared/components/signal-utils.ts | Extended signalState/signalObjectState with afterChange hooks. |
| src/webviews/apps/shared/appHost.ts | Generalized GlAppHost to accept a Provider generic. |
| src/webviews/apps/plus/graph/stateProvider.ts | Consolidated state in GraphStateProvider and added debounce logic. |
| src/webviews/apps/plus/graph/graph.ts | Adapted GraphAppHost to the new provider pattern, removed legacy theming. |
| src/webviews/apps/plus/graph/graph-wrapper/graph-wrapper.ts | Introduced theming wrapper with CSS mixing, removed legacy theming. |
| src/webviews/apps/plus/graph/graph-wrapper/gl-graph.ts | Renamed React wrapper imports to match new naming. |
| src/webviews/apps/plus/graph/graph-wrapper/gl-graph.react.tsx | Renamed GraphWrapperReact to GlGraphReact, updated props typing. |
| src/webviews/apps/plus/graph/graph-header.ts | Updated header to consume the unified state provider. |
| src/webviews/apps/plus/graph/graph-app.ts | Switched rendering and handlers to use graphState. |
| src/system/color.ts | Added getCssMixedColorValue and getCssOpacityColorValue. |
Comments suppressed due to low confidence (1)
src/webviews/apps/plus/graph/graph-wrapper/graph-wrapper.ts:346
- Consider adding unit tests for
getCssVariableValueandgetGraphThemingto validate CSS variable fallbacks and dynamic theme updates, preventing regressions in theming behavior.
function getCssVariableValue(
eamodio
reviewed
Jul 14, 2025
eamodio
reviewed
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GraphAppStateintoGraphStateProvider, reducing re-rendering due to duplicated state changesGlAppHostto support more complex state providerscolor-mix()