Skip to content

Fills type and feature fields in AI feedback events #4510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 22, 2025

Conversation

sergeibbb
Copy link
Member

@sergeibbb sergeibbb commented Jul 22, 2025

Description

Fixes #4502

  • Fills type field for generate-rebase AI event, so this field should stop being null in the feedback OTel events.
  • Adds a new feature field. So events of explain-changes family have different features: explain-branch, explain-commit, explain-stash, explain-wip

Checklist

  • I have followed the guidelines in the Contributing document
  • My changes follow the coding style of this project
  • My changes build without any errors or warnings
  • My changes have been formatted and linted
  • My changes include any required corresponding changes to the documentation (including CHANGELOG.md and README.md)
  • My changes have been rebased and squashed to the minimal number (typically 1) of relevant commits
  • My changes have a descriptive commit message with a short title, including a Fixes $XXX - or Closes #XXX - prefix to auto-close the issue that your PR addresses

@sergeibbb sergeibbb changed the title Fills type and feature fields AI feedback events Fills type and feature fields in AI feedback events Jul 22, 2025
Introduces a dedicated field to capture the feature responsible for
generating each AI result, improving clarity when handling or displaying
results. Ensures downstream consumers can reliably differentiate between
AI actions beyond their general type, supporting better analytics,
debugging, and UI handling.
(#4502, #4510)
@sergeibbb sergeibbb force-pushed the bug/4502-feedback-type-null branch from 871c50a to fac9448 Compare July 22, 2025 10:15
@d13
Copy link
Member

d13 commented Jul 22, 2025

LGTM

@sergeibbb sergeibbb merged commit 9f956db into main Jul 22, 2025
3 checks passed
@sergeibbb sergeibbb deleted the bug/4502-feedback-type-null branch July 22, 2025 15:01
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
wlnxing pushed a commit to wlnxing/vscode-gitlens that referenced this pull request Aug 19, 2025
Introduces a dedicated field to capture the feature responsible for
generating each AI result, improving clarity when handling or displaying
results. Ensures downstream consumers can reliably differentiate between
AI actions beyond their general type, supporting better analytics,
debugging, and UI handling.
(gitkraken#4502, gitkraken#4510)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'generate-rebase' feedback submissions have undefined "type"
2 participants