Skip to content

[agent-smith] introduce file detector #21010

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

kylos101
Copy link
Contributor

@kylos101 kylos101 commented Aug 15, 2025

Description

This'll warrant a new deployment for the workspace clusters, after updating the ops repo with the updated configuration.

Related Issue(s)

Fixes CLC-1701

How to test

instructions
a demo video

Documentation

Preview status

gitpod:summary

Build Options

Build
  • /werft with-werft
    Run the build with werft instead of GHA
  • leeway-no-cache
  • /werft no-test
    Run Leeway with --dont-test
Publish
  • /werft publish-to-npm
  • /werft publish-to-jb-marketplace
Installer
  • analytics=segment
  • with-dedicated-emulation
  • workspace-feature-flags
    Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
  • /werft with-local-preview
    If enabled this will build install/preview
  • /werft with-preview
  • /werft with-large-vm
  • /werft with-gce-vm
    If enabled this will create the environment on GCE infra
  • /werft preemptible
    Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
  • with-integration-tests=all
    Valid options are all, workspace, webapp, ide, jetbrains, vscode, ssh. If enabled, with-preview and with-large-vm will be enabled.
  • with-monitoring

/hold

- Add filesystem scanning capability to detect suspicious files in workspaces
- Scan workspace directories directly from WorkingArea/{InstanceID} paths
- Support filesystem signatures with filename patterns and regex matching
- Add FilesystemScanning configuration with WorkingArea path
- Integrate filesystem detection with existing signature classifier
- Fix regex pattern matching in signature matching logic
- Add comprehensive filesystem scanning tests
- Update example configuration with filesystem signatures

Co-authored-by: Ona <[email protected]>
@kylos101 kylos101 force-pushed the kb/agent-smith-filesystem-signatures branch from 389dc77 to 94cdca4 Compare August 15, 2025 03:31
@gitpod-io gitpod-io deleted a comment from gitguardian bot Aug 15, 2025
Copy link

gitguardian bot commented Aug 15, 2025

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them.
While these secrets were previously flagged, we no longer have a reference to the
specific commits where they were detected. Once a secret has been leaked into a git
repository, you should consider it compromised, even if it was deleted immediately.
Find here more information about risks.


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

@kylos101 kylos101 force-pushed the kb/agent-smith-filesystem-signatures branch from 45c4624 to a32db8d Compare August 15, 2025 04:25
@kylos101
Copy link
Contributor Author

️✅ There are no secrets present in this pull request anymore.

If these secrets were true positive and are still valid, we highly recommend you to revoke them. While these secrets were previously flagged, we no longer have a reference to the specific commits where they were detected. Once a secret has been leaked into a git repository, you should consider it compromised, even if it was deleted immediately. Find here more information about risks.

🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

It was a generated API token for the preview environment, and has been deleted, risk was limited to a non-prod ephemeral system, and is gone. 👋

Copy link
Member

@geropl geropl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One can clearly see the effort that went into this @kylos101 - impressive how you navigated the... existing "design"... in this place, and adapted in nicely made it work, without introducing breaking changes and working purely additive! Really great judgment here 💪 🚀

This makes this decision easy for me to approve, where although we don't want to invest into this software anymore, we can merge this with confidence and get exactly the relieve we were aiming for. 🎯

Code LGTM (ignore the nits, not relevant for this scope), tested and works! ✔️

@kylos101
Copy link
Contributor Author

@geropl I fixed the metrics problem and asserted that our process infringements still work, too. I'll plan to land this on Monday.

@kylos101 kylos101 marked this pull request as ready for review August 16, 2025 20:01
@kylos101 kylos101 requested a review from a team as a code owner August 16, 2025 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants