-
Notifications
You must be signed in to change notification settings - Fork 1.3k
[agent-smith] introduce file detector #21010
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
- Add filesystem scanning capability to detect suspicious files in workspaces - Scan workspace directories directly from WorkingArea/{InstanceID} paths - Support filesystem signatures with filename patterns and regex matching - Add FilesystemScanning configuration with WorkingArea path - Integrate filesystem detection with existing signature classifier - Fix regex pattern matching in signature matching logic - Add comprehensive filesystem scanning tests - Update example configuration with filesystem signatures Co-authored-by: Ona <[email protected]>
389dc77
to
94cdca4
Compare
️✅ There are no secrets present in this pull request anymore.If these secrets were true positive and are still valid, we highly recommend you to revoke them. 🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request. |
45c4624
to
a32db8d
Compare
It was a generated API token for the preview environment, and has been deleted, risk was limited to a non-prod ephemeral system, and is gone. 👋 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One can clearly see the effort that went into this @kylos101 - impressive how you navigated the... existing "design"... in this place, and adapted in nicely made it work, without introducing breaking changes and working purely additive! Really great judgment here 💪 🚀
This makes this decision easy for me to approve, where although we don't want to invest into this software anymore, we can merge this with confidence and get exactly the relieve we were aiming for. 🎯
Code LGTM (ignore the nits, not relevant for this scope), tested and works! ✔️
Co-authored-by: Ona <[email protected]>
This reverts commit 124b7ac. Co-authored-by: Ona <[email protected]>
@geropl I fixed the metrics problem and asserted that our process infringements still work, too. I'll plan to land this on Monday. |
Co-authored-by: Ona <[email protected]>
Description
This'll warrant a new deployment for the workspace clusters, after updating the ops repo with the updated configuration.
Related Issue(s)
Fixes CLC-1701
How to test
instructions
a demo video
Documentation
Preview status
gitpod:summary
Build Options
Build
Run the build with werft instead of GHA
Run Leeway with
--dont-test
Publish
Installer
Add desired feature flags to the end of the line above, space separated
Preview Environment / Integration Tests
If enabled this will build
install/preview
If enabled this will create the environment on GCE infra
Saves cost. Untick this only if you're really sure you need a non-preemtible machine.
Valid options are
all
,workspace
,webapp
,ide
,jetbrains
,vscode
,ssh
. If enabled,with-preview
andwith-large-vm
will be enabled./hold