-
Notifications
You must be signed in to change notification settings - Fork 0
Glassflow otel collector and helm values update #14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
af0cb1c
Glassflow otel collector and helm values update
ashish-bagri 3336afb
Update gh actions to generate charts.lock
ashish-bagri 55c42c7
Add metrics and configure metrics - log separtely
ashish-bagri f4138be
fix: trailing space
sudopower 00ba69a
Prepare chart values
ashish-bagri 858f9f3
Merge branch 'ETL-355' of github.com:glassflow/charts into ETL-355
ashish-bagri 48a2af2
update helm values
ashish-bagri 2492c72
fix lint errors
ashish-bagri File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -27,5 +27,8 @@ jobs: | |
- name: Set up chart-testing | ||
uses: helm/[email protected] | ||
|
||
- name: Update Helm dependencies | ||
run: helm dependency update charts/glassflow-etl | ||
|
||
- name: Run chart-testing (lint) | ||
run: ct lint --config ct.yaml |
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
64 changes: 64 additions & 0 deletions
64
charts/glassflow-etl/templates/otel-collector-configmap.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,64 @@ | ||
{{- if or .Values.global.observability.metrics.enabled .Values.global.observability.logs.enabled }} | ||
apiVersion: v1 | ||
kind: ConfigMap | ||
metadata: | ||
name: {{ .Release.Name }}-otel-collector-config | ||
namespace: {{ .Release.Namespace }} | ||
data: | ||
otel-collector-config.yaml: | | ||
receivers: | ||
otlp: | ||
protocols: | ||
grpc: | ||
endpoint: 0.0.0.0:4317 | ||
http: | ||
endpoint: 0.0.0.0:4318 | ||
|
||
processors: | ||
batch: | ||
timeout: 1s | ||
send_batch_size: 1024 | ||
resource: | ||
attributes: | ||
- key: service.name | ||
from_attribute: service.name | ||
action: insert | ||
- key: service.version | ||
from_attribute: service.version | ||
action: insert | ||
- key: service.namespace | ||
from_attribute: service.namespace | ||
action: insert | ||
|
||
exporters: | ||
{{- if .Values.global.observability.logs.enabled }} | ||
otlp: {{ toYaml .Values.global.observability.logs.exporter.otlp | nindent 8 }} | ||
{{- end }} | ||
{{- if .Values.global.observability.metrics.enabled }} | ||
prometheus: | ||
endpoint: "0.0.0.0:9090" | ||
namespace: {{ .Release.Namespace }} | ||
send_timestamps: true | ||
enable_open_metrics: true | ||
{{- end }} | ||
|
||
extensions: | ||
health_check: | ||
endpoint: 0.0.0.0:13133 | ||
|
||
service: | ||
extensions: [health_check] | ||
pipelines: | ||
{{- if .Values.global.observability.logs.enabled }} | ||
logs: | ||
receivers: [otlp] | ||
processors: [batch, resource] | ||
exporters: [otlp] | ||
{{- end }} | ||
{{- if .Values.global.observability.metrics.enabled }} | ||
metrics: | ||
receivers: [otlp] | ||
processors: [batch, resource] | ||
exporters: [prometheus] | ||
{{- end }} | ||
{{- end }} |
63 changes: 63 additions & 0 deletions
63
charts/glassflow-etl/templates/otel-collector-deployment.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,63 @@ | ||
{{- if or .Values.global.observability.metrics.enabled .Values.global.observability.logs.enabled }} | ||
apiVersion: apps/v1 | ||
kind: Deployment | ||
metadata: | ||
name: {{ .Release.Name }}-otel-collector | ||
namespace: {{ .Release.Namespace }} | ||
labels: | ||
app: {{ .Release.Name }}-otel-collector | ||
spec: | ||
replicas: 1 | ||
selector: | ||
matchLabels: | ||
app: {{ .Release.Name }}-otel-collector | ||
template: | ||
metadata: | ||
labels: | ||
app: {{ .Release.Name }}-otel-collector | ||
spec: | ||
containers: | ||
- name: {{ .Release.Name }}-otel-collector | ||
image: otel/opentelemetry-collector-contrib:0.108.0 | ||
command: | ||
- "/otelcol-contrib" | ||
- "--config=/etc/otel-collector-config.yaml" | ||
resources: | ||
requests: | ||
cpu: 100m | ||
memory: 128Mi | ||
limits: | ||
cpu: 500m | ||
memory: 512Mi | ||
ports: | ||
- containerPort: 4317 | ||
name: otlp-grpc | ||
- containerPort: 4318 | ||
name: otlp-http | ||
{{- if .Values.global.observability.metrics.enabled }} | ||
- containerPort: 9090 | ||
name: prometheus | ||
{{- end }} | ||
- containerPort: 13133 | ||
name: health-check | ||
volumeMounts: | ||
- name: config | ||
mountPath: /etc/otel-collector-config.yaml | ||
subPath: otel-collector-config.yaml | ||
livenessProbe: | ||
httpGet: | ||
path: / | ||
port: 13133 | ||
initialDelaySeconds: 30 | ||
periodSeconds: 30 | ||
readinessProbe: | ||
httpGet: | ||
path: / | ||
port: 13133 | ||
initialDelaySeconds: 5 | ||
periodSeconds: 10 | ||
volumes: | ||
- name: config | ||
configMap: | ||
name: {{ .Release.Name }}-otel-collector-config | ||
{{- end }} |
24 changes: 24 additions & 0 deletions
24
charts/glassflow-etl/templates/otel-collector-service.yaml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,24 @@ | ||
{{- if or .Values.global.observability.metrics.enabled .Values.global.observability.logs.enabled }} | ||
apiVersion: v1 | ||
kind: Service | ||
metadata: | ||
name: {{ .Release.Name }}-otel-collector | ||
namespace: {{ .Release.Namespace }} | ||
labels: | ||
app: {{ .Release.Name }}-otel-collector | ||
spec: | ||
ports: | ||
- name: otlp-grpc | ||
port: 4317 | ||
targetPort: 4317 | ||
- name: otlp-http | ||
port: 4318 | ||
targetPort: 4318 | ||
{{- if .Values.global.observability.metrics.enabled }} | ||
- name: prometheus | ||
port: 9090 | ||
targetPort: 9090 | ||
{{- end }} | ||
selector: | ||
app: {{ .Release.Name }}-otel-collector | ||
{{- end }} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.