Skip to content

Conversation

ichiriac
Copy link
Member

@ichiriac ichiriac commented Jan 2, 2020

related to a discussion on #455 - @czosel you are welcome to contribute on this :

  • We could use benchmark.js framework as the results may be more accurate
  • Add a traking JSON test/perf/statistics.json
  • At each run lookup if there is a result entry
  • Scan the test/perf folder for php files, and on each run tests on tokens & nodes (and check the threshold)
  • If entry found, check with the threshold if the performance is ok
  • If no entry, at the end of tests, create one and update the JSON file
  • Add more tests to cover various use cases (but keep them generic enough to be run on php7.0)
  • Checkout previous release tags and try to get performance statistics on each in order to see if performance has been degraded

@ichiriac
Copy link
Member Author

ichiriac commented Jan 2, 2020

related to #57

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.143% when pulling 492bcfb on performance_tracking into 407e4d4 on master.

@ichiriac ichiriac added this to the 3.1.0 milestone Jan 6, 2020
@ichiriac ichiriac self-assigned this Jan 9, 2020
@czosel czosel mentioned this pull request Feb 26, 2022
@czosel
Copy link
Collaborator

czosel commented Feb 26, 2022

Landed in #885

@czosel czosel closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants