Sort completions by type #5119
Merged
Sort completions by type #5119
+471
−148
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GearsDatapacks
force-pushed
the
sort-completions-by-type
branch
2 times, most recently
from
ab55c48 to
0d4f0e4
Compare
GearsDatapacks
force-pushed
the
sort-completions-by-type
branch
from
0d4f0e4 to
4969632
Compare
lpil
reviewed
Nov 20, 2025
Member
lpil
left a comment
lpil
left a comment
There was a problem hiding this comment.
Thank you!! Left some tiny notes inline
Member
|
Sorry Gears, would you mind rebasing on main? 🙏 |
GearsDatapacks
force-pushed
the
sort-completions-by-type
branch
from
a189de2 to
50eafd4
Compare
Member
Author
|
Done! |
GearsDatapacks
force-pushed
the
sort-completions-by-type
branch
from
50eafd4 to
ed86cc3
Compare
GearsDatapacks
force-pushed
the
sort-completions-by-type
branch
from
ed86cc3 to
676bd77
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #5058
This PR changes the autocomplete provider to prioritise values which match the expected type of the expression being completed.