feat: Add support for unevaluatedProperties in JSON Schema #2800
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds support for the
unevaluatedProperties
keyword from JSON Schema draft 2019-09/2020-12.Problem
When using JSON Schema with
unevaluatedProperties
, quicktype was generating incorrect types. For example, in Go, it would generatemap[string]interface{}
instead of properly typed maps likemap[string][]SomeType
.Solution
When
additionalProperties
is not defined in a schema, quicktype now falls back to usingunevaluatedProperties
to determine the type of additional properties in an object.Changes
JSONSchemaInput.ts
to handleunevaluatedProperties
whenadditionalProperties
is undefinedunevaluatedProperties
Test
Added test schema and data files:
test/inputs/schema/unevaluated-properties.schema
test/inputs/schema/unevaluated-properties.1.json
test/inputs/schema/unevaluated-properties.2.json
The tests can be run with:
QUICKTEST=true FIXTURE=schema-golang npm test
Example
Before this fix:
After this fix: