Skip to content

Allow client to use port 0 when requesting reverse port forwarding #167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Allow client to use port 0 when requesting reverse port forwarding #167

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd810c5
Allow client to use port 0 when requesting reverse port forwarding
rawoul Nov 25, 2021
4965f63
fix multiple ports forward requests to port 0
Oct 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 8 additions & 4 deletions tcpip.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -108,17 +108,21 @@ func (h *ForwardedTCPHandler) HandleSSHRequest(ctx Context, srv *Server, req *go
// TODO: log parse failure
return false, []byte{}
}
if srv.ReversePortForwardingCallback == nil || !srv.ReversePortForwardingCallback(ctx, reqPayload.BindAddr, reqPayload.BindPort) {
return false, []byte("port forwarding is disabled")
}
addr := net.JoinHostPort(reqPayload.BindAddr, strconv.Itoa(int(reqPayload.BindPort)))
ln, err := net.Listen("tcp", addr)
if err != nil {
// TODO: log listen failure
return false, []byte{}
} else {
// addr might not be valid anymore if bind port was 0
addr = ln.Addr().String()
}
_, destPortStr, _ := net.SplitHostPort(ln.Addr().String())
_, destPortStr, _ := net.SplitHostPort(addr)
destPort, _ := strconv.Atoi(destPortStr)
if srv.ReversePortForwardingCallback == nil || !srv.ReversePortForwardingCallback(ctx, reqPayload.BindAddr, uint32(destPort)) {
ln.Close()
return false, []byte("port forwarding is disabled")
}
h.Lock()
h.forwards[addr] = ln
h.Unlock()
Expand Down