-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Fix dropdown custom field search options #21175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix dropdown custom field search options #21175
Conversation
Tests are failing |
You cannot use CAST with JSON datatype. JSON is only a valid datatype in MySQL. |
Indeed, there is something missing to make this code compatible with both MySQL and MariaDB. |
The point of the QueryFunction class refactoring was to allow better compatibility between DBMS. Maybe calls to I don't know how useful I am going to be today. I haven't had much sleep. |
a76a0fd
to
8d1f578
Compare
6e34449
to
5fbcdb2
Compare
5fbcdb2
to
b05f497
Compare
Checklist before requesting a review
Description
Fixes #21162
Fix condition for dropdown custom field search option joins when multiple selection are allowed.
Fix usage of
glpi_assets_assets
table instead ofREFTABLE
in join conditions.Add dropdown custom fields (single and multiple) to test dataset for automatic search tests to take them into account.