feat: Support Swift's libBlocksRuntime #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @ngrewe! @hmelder with this merged can/should we switch to the libdispatch blocks runtime by removing this patch and building libdispatch before libobjc2? |
|
I would stick to the libobjc2 runtime and study the implementation in swift first. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some time ago, I added support in libobjc2 to using libBlocksRuntime as supplied by Swift's libdispatch instead of the embedded blocks runtime. This was done to alleviate the longstanding issue that both provided the same symbols which made properly packaging libobjc2 in distributions that also package libBlocksRuntime a bit of a hassle.
This PR changes gnustep-make to detect whether it needs to pull in libBlocksRuntime for blocks support. I also extracted the blocks feature checks into a separate m4 file and fixed a small typo in
gs_objc_runtime.m4.