Skip to content

Conversation

BeChris
Copy link

@BeChris BeChris commented Jan 11, 2025

Necessary to fix go-git/go-git#1371

@@ -14,7 +14,7 @@ import (
)

const (
defaultDirectoryMode = 0o755
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add some tests to confirm the new behaviour - so that we don't have a regression in the future.

0xDEC0DE added a commit to 0xDEC0DE/go-billy that referenced this pull request Apr 9, 2025
a reprise of go-git#104, with added tests

The tests for `ChrootFS` do not work with a memfs backend, because
memfs creates parent directories with bonkers permissions.

drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE added a commit to 0xDEC0DE/go-billy that referenced this pull request Apr 24, 2025
a reprise of go-git#104, with added tests

Limited the scope of the CreateWithChroot tests to OsFs, because
MemFs creates parent directories with bonkers permissions.

drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE added a commit to 0xDEC0DE/go-billy that referenced this pull request Apr 27, 2025
a reprise of go-git#104, with added tests

Limited the scope of the CreateWithChroot tests to OsFs, because
MemFs creates parent directories with bonkers permissions.

drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE added a commit to 0xDEC0DE/go-billy that referenced this pull request Apr 28, 2025
a reprise of go-git#104, with added tests

Limited the scope of the CreateWithChroot tests to OsFs, because
MemFs creates parent directories with bonkers permissions.

drive-by: add Makefile variables for `make test-coverage` to run successfully
0xDEC0DE added a commit to 0xDEC0DE/go-billy that referenced this pull request Aug 7, 2025
a reprise of go-git#104, with added tests

Limited the scope of the CreateWithChroot tests to OsFs, because
MemFs creates parent directories with bonkers permissions.

drive-by: add Makefile variables for `make test-coverage` to run successfully
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git.PlainCloneContext doesn't obey umask.
2 participants