Skip to content

Add test for IsUserAllowedToMerge with action user #31094

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

Add test for IsUserAllowedToMerge with action user #31094

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
95c31f8
Add test for IsUserAllowedToMerge with action user
lunny May 27, 2024
5e3eb84
Fix lint
lunny May 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions services/pull/merge_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,13 @@ package pull
import (
"testing"

"code.gitea.io/gitea/models/db"
issues_model "code.gitea.io/gitea/models/issues"
"code.gitea.io/gitea/models/perm/access"
repo_model "code.gitea.io/gitea/models/repo"
"code.gitea.io/gitea/models/unittest"
"code.gitea.io/gitea/models/user"

"github.com/stretchr/testify/assert"
)

Expand Down Expand Up @@ -65,3 +72,16 @@ func Test_expandDefaultMergeMessage(t *testing.T) {
})
}
}

func Test_IsUserAllowedToMerge(t *testing.T) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
func Test_IsUserAllowedToMerge(t *testing.T) {
func Test_ActionsUserCannotMerge(t *testing.T) {

assert.NoError(t, unittest.PrepareTestDatabase())
pr := unittest.AssertExistsAndLoadBean(t, &issues_model.PullRequest{ID: 2})
repo := unittest.AssertExistsAndLoadBean(t, &repo_model.Repository{ID: pr.BaseRepoID})

perm, err := access.GetUserRepoPermission(db.DefaultContext, repo, user.NewActionsUser())
assert.NoError(t, err)

allowed, err := IsUserAllowedToMerge(db.DefaultContext, pr, perm, user.NewActionsUser())
assert.NoError(t, err)
assert.False(t, allowed)
}