Manage User Badges in the UI #31262
Manage User Badges in the UI #31262
Conversation
GiteaBot
added
the
lgtm/need 2
github-actions
bot
added
modifies/translation
modifies/go
Thank you so much! |
Co-authored-by: Diogo Vicente <[email protected]>
Co-authored-by: Diogo Vicente <[email protected]>
|
@HenriquerPimentel looks like some different CI steps are failing, also related to linting (some public go functions require comments to document their purpose, eg As a sidenote: force pushing erases some review history as GitHub sees some files as new (even if they remain the same). If you could reduce your force pushes, it'd be helpful to me as a reviewer so I can keep track of what I've seen already |
|
@lunny @wxiaoguang thanks for your feedback. I've updated this PR per your reviews. I also cherry-picked changes from #33950 by @komarov (I set you as the commit author, but the GUI only shows that in one specific place, as it has me as the "committer". GH has you as a co-author in the commit trailing bits for when this PR is squashed/merged) |
GiteaBot
added
lgtm/need 1
| @@ -603,12 +605,15 @@ unknown_error = Unknown error: | |||
| captcha_incorrect = The CAPTCHA code is incorrect. | |||
| password_not_match = The passwords do not match. | |||
| lang_select_error = Select a language from the list. | |||
| invalid_image_url_error = `Please provide a valid image URL.` | |||
| invalid_slug_error = `Please provide a valid slug.` | |||
There was a problem hiding this comment.
Crowdin doesn't work with back-quote
| switch { | ||
| default: | ||
| ctx.ServerError("UpdateBadge", err) | ||
| } |
There was a problem hiding this comment.
only switch-default?
(many places)
| b.ImageURL = form.ImageURL | ||
| b.Description = form.Description | ||
|
|
||
| if err := user_model.UpdateBadge(ctx, ctx.Data["Badge"].(*user_model.Badge)); err != nil { |
There was a problem hiding this comment.
Why it uses dynamic type here ctx.Data["Badge"].(*user_model.Badge))? There should be a static typed variable "badge"
| page := ctx.FormInt("page") | ||
| if page <= 0 { | ||
| page = 1 | ||
| } |
| if user_model.IsErrBadgeNotExist(err) { | ||
| ctx.Flash.Error(ctx.Tr("admin.badges.not_found")) | ||
| } else { | ||
| ctx.ServerError("AddUserBadge", err) | ||
| } | ||
| return |
There was a problem hiding this comment.
ctx.Flash.Error + return is wrong
(many places)
| func RenderBadgeSearch(ctx *context.Context, opts *user_model.SearchBadgeOptions, tplName templates.TplName) { | ||
| // Sitemap index for sitemap paths | ||
| opts.Page = int(ctx.PathParamInt64("idx")) |
There was a problem hiding this comment.
Why "sitemap" in the "admin" routes?
| type AdminCreateBadgeForm struct { | ||
| Slug string `binding:"Required;Slug"` | ||
| Description string `binding:"Required"` | ||
| ImageURL string `binding:"ValidImageUrl"` |
Implemented #29798
This feature implements:
Implemented Badge Management in administration panel
9 Added new translation phrases (en-US): search.badge_kind, form.ImageURL, form.invalid_image_url_error, form.slug_been_taken, admin.badges, admin.badges.badges_manage_panel, admin.badges.details, admin.badges.new_badge, admin.badges.slug, admin.badges.description, admin.badges.image_url, admin.badges.slug.must_fill, admin.badges.new_success, admin.badges.update_success, admin.badges.deletion_success, admin.badges.edit_badge, admin.badges.update_badge, admin.badges.delete_badge, admin.badges.delete_badge_desc
Implemented User Badge Management Interface