Rewrite compare functions #32786
Open
Rewrite compare functions #32786
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
lunny
commented
Dec 10, 2024
wxiaoguang
reviewed
Dec 10, 2024
github-actions
bot
added
the
modifies/api
lunny
changed the title
lunny
changed the title
Closed
|
This is ready to review now. |
yp05327
reviewed
Jan 9, 2025
… lunny/refactor_getpatch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR rewrites the compare functions to make the logic clearer and readable.
Carets compare has never been handled correctly. This PR will make it easier to be implemented in future PRs.