Allow code review comments crossing commit with right line number

models/issues/comment.go

@@ -293,7 +293,8 @@ type Comment struct {
 	UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
 
 	// Reference issue in commit message
-	CommitSHA string `xorm:"VARCHAR(64)"`
+	BeforeCommitID string `xorm:"VARCHAR(64)"`
+	CommitSHA      string `xorm:"VARCHAR(64)"`
 
 	Attachments []*repo_model.Attachment `xorm:"-"`
 	Reactions   ReactionList             `xorm:"-"`
@@ -764,6 +765,10 @@ func (c *Comment) CodeCommentLink(ctx context.Context) string {
 	return fmt.Sprintf("%s/files#%s", c.Issue.Link(), c.HashTag())
 }
 
+func GetCodeCommentRefName(prIndex, commentID int64, suffix string) string {
+	return fmt.Sprintf("refs/pull/%d/code-comment-%d", prIndex, commentID)
+}
+
 // CreateComment creates comment with context
 func CreateComment(ctx context.Context, opts *CreateCommentOptions) (_ *Comment, err error) {
 	return db.WithTx2(ctx, func(ctx context.Context) (*Comment, error) {
@@ -796,6 +801,7 @@ func CreateComment(ctx context.Context, opts *CreateCommentOptions) (_ *Comment,
 			AssigneeID:       opts.AssigneeID,
 			AssigneeTeamID:   opts.AssigneeTeamID,
 			CommitID:         opts.CommitID,
+			BeforeCommitID:   opts.BeforeCommitID,
 			CommitSHA:        opts.CommitSHA,
 			Line:             opts.LineNum,
 			Content:          opts.Content,
@@ -965,7 +971,8 @@ type CreateCommentOptions struct {
 	OldRef             string
 	NewRef             string
 	CommitID           int64
-	CommitSHA          string
+	BeforeCommitID     string // before commit id when creating this code comment
+	CommitSHA          string // after commit id when creating this code comment, ref commit id for other comment
 	Patch              string
 	LineNum            int64
 	TreePath           string

models/issues/comment_code.go

@@ -9,46 +9,52 @@ import (
 
 	"code.gitea.io/gitea/models/db"
 	"code.gitea.io/gitea/models/renderhelper"
+	repo_model "code.gitea.io/gitea/models/repo"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/markup/markdown"
 
 	"xorm.io/builder"
 )
 
 // CodeComments represents comments on code by using this structure: FILENAME -> LINE (+ == proposed; - == previous) -> COMMENTS
-type CodeComments map[string]map[int64][]*Comment
+type CodeComments map[string][]*Comment
+
+func (cc CodeComments) AllComments() []*Comment {
+	var allComments []*Comment
+	for _, comments := range cc {
+		allComments = append(allComments, comments...)
+	}
+	return allComments
+}
 
 // FetchCodeComments will return a 2d-map: ["Path"]["Line"] = Comments at line
-func FetchCodeComments(ctx context.Context, issue *Issue, currentUser *user_model.User, showOutdatedComments bool) (CodeComments, error) {
-	return fetchCodeCommentsByReview(ctx, issue, currentUser, nil, showOutdatedComments)
+func FetchCodeComments(ctx context.Context, repo *repo_model.Repository, issueID int64, currentUser *user_model.User, showOutdatedComments bool) (CodeComments, error) {
+	return fetchCodeCommentsByReview(ctx, repo, issueID, currentUser, nil, showOutdatedComments)
 }
 
-func fetchCodeCommentsByReview(ctx context.Context, issue *Issue, currentUser *user_model.User, review *Review, showOutdatedComments bool) (CodeComments, error) {
-	pathToLineToComment := make(CodeComments)
+func fetchCodeCommentsByReview(ctx context.Context, repo *repo_model.Repository, issueID int64, currentUser *user_model.User, review *Review, showOutdatedComments bool) (CodeComments, error) {
+	codeCommentsPathMap := make(CodeComments)
 	if review == nil {
 		review = &Review{ID: 0}
 	}
 	opts := FindCommentsOptions{
 		Type:     CommentTypeCode,
-		IssueID:  issue.ID,
+		IssueID:  issueID,
 		ReviewID: review.ID,
 	}
 
-	comments, err := findCodeComments(ctx, opts, issue, currentUser, review, showOutdatedComments)
+	comments, err := FindCodeComments(ctx, opts, repo, currentUser, review, showOutdatedComments)
 	if err != nil {
 		return nil, err
 	}
 
 	for _, comment := range comments {
-		if pathToLineToComment[comment.TreePath] == nil {
-			pathToLineToComment[comment.TreePath] = make(map[int64][]*Comment)
-		}
-		pathToLineToComment[comment.TreePath][comment.Line] = append(pathToLineToComment[comment.TreePath][comment.Line], comment)
+		codeCommentsPathMap[comment.TreePath] = append(codeCommentsPathMap[comment.TreePath], comment)
 	}
-	return pathToLineToComment, nil
+	return codeCommentsPathMap, nil
 }
 
-func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issue, currentUser *user_model.User, review *Review, showOutdatedComments bool) ([]*Comment, error) {
+func FindCodeComments(ctx context.Context, opts FindCommentsOptions, repo *repo_model.Repository, currentUser *user_model.User, review *Review, showOutdatedComments bool) ([]*Comment, error) {
 	var comments CommentList
 	if review == nil {
 		review = &Review{ID: 0}
@@ -67,10 +73,6 @@ func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issu
 		return nil, err
 	}
 
-	if err := issue.LoadRepo(ctx); err != nil {
-		return nil, err
-	}
-
 	if err := comments.LoadPosters(ctx); err != nil {
 		return nil, err
 	}
@@ -110,12 +112,12 @@ func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issu
 			return nil, err
 		}
 
-		if err := comment.LoadReactions(ctx, issue.Repo); err != nil {
+		if err := comment.LoadReactions(ctx, repo); err != nil {
 			return nil, err
 		}
 
 		var err error
-		rctx := renderhelper.NewRenderContextRepoComment(ctx, issue.Repo, renderhelper.RepoCommentOptions{
+		rctx := renderhelper.NewRenderContextRepoComment(ctx, repo, renderhelper.RepoCommentOptions{
 			FootnoteContextID: strconv.FormatInt(comment.ID, 10),
 		})
 		if comment.RenderedContent, err = markdown.RenderString(rctx, comment.Content); err != nil {
@@ -124,14 +126,3 @@ func findCodeComments(ctx context.Context, opts FindCommentsOptions, issue *Issu
 	}
 	return comments[:n], nil
 }
-
-// FetchCodeCommentsByLine fetches the code comments for a given treePath and line number
-func FetchCodeCommentsByLine(ctx context.Context, issue *Issue, currentUser *user_model.User, treePath string, line int64, showOutdatedComments bool) (CommentList, error) {
-	opts := FindCommentsOptions{
-		Type:     CommentTypeCode,
-		IssueID:  issue.ID,
-		TreePath: treePath,
-		Line:     line,
-	}
-	return findCodeComments(ctx, opts, issue, currentUser, nil, showOutdatedComments)
-}

models/issues/comment_test.go

@@ -68,15 +68,20 @@ func TestFetchCodeComments(t *testing.T) {
 
 	issue := unittest.AssertExistsAndLoadBean(t, &issues_model.Issue{ID: 2})
 	user := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 1})
-	res, err := issues_model.FetchCodeComments(t.Context(), issue, user, false)
+	res, err := issues_model.FetchCodeComments(t.Context(), issue.Repo, issue.ID, user, false)
 	assert.NoError(t, err)
 	assert.Contains(t, res, "README.md")
-	assert.Contains(t, res["README.md"], int64(4))
-	assert.Len(t, res["README.md"][4], 1)
-	assert.Equal(t, int64(4), res["README.md"][4][0].ID)
+	fourthLineComments := []*issues_model.Comment{}
+	for _, comment := range res["README.md"] {
+		if comment.Line == 4 {
+			fourthLineComments = append(fourthLineComments, comment)
+		}
+	}
+	assert.Len(t, fourthLineComments, 1)
+	assert.Equal(t, int64(4), fourthLineComments[0].ID)
 
 	user2 := unittest.AssertExistsAndLoadBean(t, &user_model.User{ID: 2})
-	res, err = issues_model.FetchCodeComments(t.Context(), issue, user2, false)
+	res, err = issues_model.FetchCodeComments(t.Context(), issue.Repo, issue.ID, user2, false)
 	assert.NoError(t, err)
 	assert.Len(t, res, 1)
 }

models/issues/issue.go

@@ -223,7 +223,7 @@ func (issue *Issue) LoadPullRequest(ctx context.Context) (err error) {
 	return nil
 }
 
-func (issue *Issue) loadComments(ctx context.Context) (err error) {
+func (issue *Issue) LoadComments(ctx context.Context) (err error) {
 	return issue.loadCommentsByType(ctx, CommentTypeUndefined)
 }
 
@@ -344,7 +344,7 @@ func (issue *Issue) LoadAttributes(ctx context.Context) (err error) {
 		return err
 	}
 
-	if err = issue.loadComments(ctx); err != nil {
+	if err = issue.LoadComments(ctx); err != nil {
 		return err
 	}
 

models/issues/pull.go

@@ -15,7 +15,6 @@ import (
 	"code.gitea.io/gitea/models/db"
 	git_model "code.gitea.io/gitea/models/git"
 	org_model "code.gitea.io/gitea/models/organization"
-	pull_model "code.gitea.io/gitea/models/pull"
 	repo_model "code.gitea.io/gitea/models/repo"
 	user_model "code.gitea.io/gitea/models/user"
 	"code.gitea.io/gitea/modules/git"
@@ -158,26 +157,6 @@ func init() {
 	db.RegisterModel(new(PullRequest))
 }
 
-// DeletePullsByBaseRepoID deletes all pull requests by the base repository ID
-func DeletePullsByBaseRepoID(ctx context.Context, repoID int64) error {
-	deleteCond := builder.Select("id").From("pull_request").Where(builder.Eq{"pull_request.base_repo_id": repoID})
-
-	// Delete scheduled auto merges
-	if _, err := db.GetEngine(ctx).In("pull_id", deleteCond).
-		Delete(&pull_model.AutoMerge{}); err != nil {
-		return err
-	}
-
-	// Delete review states
-	if _, err := db.GetEngine(ctx).In("pull_id", deleteCond).
-		Delete(&pull_model.ReviewState{}); err != nil {
-		return err
-	}
-
-	_, err := db.DeleteByBean(ctx, &PullRequest{BaseRepoID: repoID})
-	return err
-}
-
 func (pr *PullRequest) String() string {
 	if pr == nil {
 		return "<PullRequest nil>"
@@ -412,11 +391,16 @@ func (pr *PullRequest) getReviewedByLines(ctx context.Context, writer io.Writer)
 	return nil
 }
 
-// GetGitHeadRefName returns git ref for hidden pull request branch
+// GetGitHeadRefName returns git head commit id ref for the pull request's branch
 func (pr *PullRequest) GetGitHeadRefName() string {
 	return fmt.Sprintf("%s%d/head", git.PullPrefix, pr.Index)
 }
 
+// GetGitMergeRefName returns git merged commit id ref for the pull request
+func (pr *PullRequest) GetGitMergeRefName() string {
+	return fmt.Sprintf("%s%d/merge", git.PullPrefix, pr.Index)
+}
+
 // GetReviewCommentsCount returns the number of review comments made on the diff of a PR review (not including comments on commits or issues in a PR)
 func (pr *PullRequest) GetReviewCommentsCount(ctx context.Context) int {
 	opts := FindCommentsOptions{

models/issues/review.go

@@ -159,7 +159,7 @@ func (r *Review) LoadCodeComments(ctx context.Context) (err error) {
 	if err = r.LoadIssue(ctx); err != nil {
 		return err
 	}
-	r.CodeComments, err = fetchCodeCommentsByReview(ctx, r.Issue, nil, r, false)
+	r.CodeComments, err = fetchCodeCommentsByReview(ctx, r.Issue.Repo, r.Issue.ID, nil, r, false)
 	return err
 }
 
@@ -429,6 +429,10 @@ func SubmitReview(ctx context.Context, doer *user_model.User, issue *Issue, revi
 	defer committer.Close()
 	sess := db.GetEngine(ctx)
 
+	if err := issue.LoadRepo(ctx); err != nil {
+		return nil, nil, fmt.Errorf("LoadRepo: %w", err)
+	}
+
 	official := false
 
 	review, err := GetCurrentReview(ctx, doer, issue)

models/issues/review_test.go

@@ -47,7 +47,7 @@ func TestReview_LoadCodeComments(t *testing.T) {
 	assert.NoError(t, review.LoadAttributes(t.Context()))
 	assert.NoError(t, review.LoadCodeComments(t.Context()))
 	assert.Len(t, review.CodeComments, 1)
-	assert.Equal(t, int64(4), review.CodeComments["README.md"][int64(4)][0].Line)
+	assert.Equal(t, int64(4), review.CodeComments["README.md"][0].Line)
 }
 
 func TestReviewType_Icon(t *testing.T) {

models/migrations/migrations.go

@@ -395,6 +395,7 @@ func prepareMigrationTasks() []*migration {
 		newMigration(321, "Use LONGTEXT for some columns and fix review_state.updated_files column", v1_25.UseLongTextInSomeColumnsAndFixBugs),
 		newMigration(322, "Extend comment tree_path length limit", v1_25.ExtendCommentTreePathLength),
 		newMigration(323, "Add support for actions concurrency", v1_25.AddActionsConcurrency),
+		newMigration(324, "Add BeforeCommitID to Comment table", v1_25.AddBeforeCommitIDForComment),
 	}
 	return preparedMigrations
 }

models/migrations/v1_25/v322_test.go

@@ -0,0 +1,103 @@
+// Copyright 2025 The Gitea Authors. All rights reserved.
+// SPDX-License-Identifier: MIT
+
+package v1_25
+
+import (
+	"testing"
+
+	"code.gitea.io/gitea/models/migrations/base"
+	"code.gitea.io/gitea/modules/references"
+	"code.gitea.io/gitea/modules/timeutil"
+
+	"github.com/stretchr/testify/assert"
+)
+
+func Test_AddBeforeCommitIDForComment(t *testing.T) {
+	type Comment struct { // old struct
+		ID               int64 `xorm:"pk autoincr"`
+		Type             int   `xorm:"INDEX"`
+		PosterID         int64 `xorm:"INDEX"`
+		OriginalAuthor   string
+		OriginalAuthorID int64
+		IssueID          int64 `xorm:"INDEX"`
+		LabelID          int64
+		OldProjectID     int64
+		ProjectID        int64
+		OldMilestoneID   int64
+		MilestoneID      int64
+		TimeID           int64
+		AssigneeID       int64
+		RemovedAssignee  bool
+		AssigneeTeamID   int64 `xorm:"NOT NULL DEFAULT 0"`
+		ResolveDoerID    int64
+		OldTitle         string
+		NewTitle         string
+		OldRef           string
+		NewRef           string
+		DependentIssueID int64 `xorm:"index"` // This is used by issue_service.deleteIssue
+
+		CommitID       int64
+		Line           int64 // - previous line / + proposed line
+		TreePath       string
+		Content        string `xorm:"LONGTEXT"`
+		ContentVersion int    `xorm:"NOT NULL DEFAULT 0"`
+
+		// Path represents the 4 lines of code cemented by this comment
+		Patch       string `xorm:"-"`
+		PatchQuoted string `xorm:"LONGTEXT patch"`
+
+		CreatedUnix timeutil.TimeStamp `xorm:"INDEX created"`
+		UpdatedUnix timeutil.TimeStamp `xorm:"INDEX updated"`
+
+		// Reference issue in commit message
+		CommitSHA string `xorm:"VARCHAR(64)"`
+
+		ReviewID    int64 `xorm:"index"`
+		Invalidated bool
+
+		// Reference an issue or pull from another comment, issue or PR
+		// All information is about the origin of the reference
+		RefRepoID    int64                 `xorm:"index"` // Repo where the referencing
+		RefIssueID   int64                 `xorm:"index"`
+		RefCommentID int64                 `xorm:"index"`    // 0 if origin is Issue title or content (or PR's)
+		RefAction    references.XRefAction `xorm:"SMALLINT"` // What happens if RefIssueID resolves
+		RefIsPull    bool
+
+		CommentMetaData string `xorm:"JSON TEXT"` // put all non-index metadata in a single field
+	}
+
+	type PullRequest struct {
+		ID              int64 `xorm:"pk autoincr"`
+		Type            int
+		Status          int
+		ConflictedFiles []string `xorm:"TEXT JSON"`
+		CommitsAhead    int
+		CommitsBehind   int
+
+		ChangedProtectedFiles []string `xorm:"TEXT JSON"`
+
+		IssueID int64 `xorm:"INDEX"`
+		Index   int64
+
+		HeadRepoID          int64 `xorm:"INDEX"`
+		BaseRepoID          int64 `xorm:"INDEX"`
+		HeadBranch          string
+		BaseBranch          string
+		MergeBase           string `xorm:"VARCHAR(64)"`
+		AllowMaintainerEdit bool   `xorm:"NOT NULL DEFAULT false"`
+
+		HasMerged      bool               `xorm:"INDEX"`
+		MergedCommitID string             `xorm:"VARCHAR(64)"`
+		MergerID       int64              `xorm:"INDEX"`
+		MergedUnix     timeutil.TimeStamp `xorm:"updated INDEX"`
+
+		Flow int `xorm:"NOT NULL DEFAULT 0"`
+	}
+
+	// Prepare and load the testing database
+	x, deferable := base.PrepareTestEnv(t, 0, new(Comment), new(PullRequest))
+	defer deferable()
+
+	assert.NoError(t, AddBeforeCommitIDForComment(x))
+}