Remove deprecated auth sources #35272
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Entra ID users should use the OIDC oauth2 provider
GiteaBot
added
the
lgtm/need 2
lunny
reviewed
Aug 15, 2025
lunny
reviewed
Aug 15, 2025
6543
approved these changes
Aug 17, 2025
GiteaBot
added
lgtm/need 1
lunny
reviewed
Aug 18, 2025
lunny
approved these changes
Aug 18, 2025
GiteaBot
added
lgtm/done
lunny
added
the
reviewed/wait-merge
delvh
reviewed
Aug 18, 2025
| return nil | ||
| } | ||
|
|
||
| var existingAzureProviders []string |
There was a problem hiding this comment.
Wouldn't it make sense to check this in SQL (WHERE provider IN ('…'))?
| providers := make([]Provider, 0, len(gothProviders)) | ||
| existAuthSources := getExistingAzureADAuthSources(ctx) |
|
|
||
| for _, provider := range gothProviders { | ||
| if slices.Contains(azureProviders, provider.Name()) && !slices.Contains(existAuthSources, provider.Name()) { |
There was a problem hiding this comment.
Isn't that an gothProviders = gothProviders.Remove(existingAzureSources)?
(Although it will probably look different since the stdlib doesn't seem to support that method…)
techknowlogick
removed
the
reviewed/wait-merge
wxiaoguang
reviewed
Aug 19, 2025
Comment on lines
+95
to
+100
| authSources, err := db.Find[auth.Source](ctx, auth.FindSourcesOptions{ | ||
| LoginType: auth.OAuth2, | ||
| }) | ||
| if err != nil { | ||
| return nil | ||
| } |
There was a problem hiding this comment.
It shouldn't silently ignore an unknown error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Entra ID users should use the OIDC oauth2 provider.
They will still be shown if the instance has a previous Azure AD source configured.