Skip to content

Remove git.Commit referenced Tree object to let it portable #35356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Remove git.Commit referenced Tree object to let it portable #35356

wants to merge 19 commits into from
+708 −695

Conversation

lunny
Copy link
Member

@lunny lunny commented Aug 25, 2025 •
edited
Loading

This PR removes a flawed design where git.Commit depended on git.Tree, and git.Tree in turn depended on git.Repository.

Now, git.Commit only stores the TreeID as a field. To retrieve the tree of a commit, you can use NewTree.

This change makes git.Commit more portable, allowing commit objects to be transferred across machines when necessary.

  • Moved submoduleCache to Tree as field and rename CommitSubmoduleFile to SubmoduleFile

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label Aug 25, 2025
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Aug 25, 2025
@github-actions github-actions bot added modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code labels Aug 25, 2025
@lunny lunny marked this pull request as draft August 25, 2025 18:19
@lunny lunny force-pushed the lunny/remove_repo_ref_in_commit branch from fc59665 to 4a8637f Compare August 25, 2025 19:36
@lunny lunny changed the title Remove git.Commit referenced repo to let it portable Remove git.Commit referenced Tree object to let it portable Aug 25, 2025
@lunny lunny marked this pull request as ready for review August 26, 2025 03:28
@lunny lunny requested a review from wxiaoguang August 27, 2025 19:22
@lunny lunny added this to the 1.26.0 milestone Sep 26, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wxiaoguang wxiaoguang Awaiting requested review from wxiaoguang

Assignees
No one assigned
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. modifies/api This PR adds API routes or modifies them modifies/go Pull requests that update Go code type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.26.0
Development

Successfully merging this pull request may close these issues.
2 participants
@lunny @GiteaBot