Stabilize import order #526
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #526 +/- ##
==========================================
- Coverage 92.18% 92.18% -0.01%
==========================================
Files 139 139
Lines 8576 8572 -4
==========================================
- Hits 7906 7902 -4
Misses 493 493
Partials 177 177 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Owner
|
go-jet
reviewed
Nov 9, 2025
| importPaths[importPath] = true | ||
| if importPath != "" && !seen[importPath] { | ||
| ret = append(ret, importPath) | ||
| } |
Owner
There was a problem hiding this comment.
Not sure, how this change would stabilize import order??
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import order of generated model files changes from time to time. It causes a large number of file changes in my current working project. Stable import order might be solution for this.
Running
gofmtafter generation may be an alternative, but I don't think anyone could be in favor of unstable import order.