Skip to content

fix(replication): calculate LogPos for non-artificial events in MariaDB 11.4+ #1052

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 15, 2025
Merged

fix(replication): calculate LogPos for non-artificial events in MariaDB 11.4+ #1052

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd31578
fix(replication): calculate LogPos for non-artificial events in Maria…
mefcorvi Jul 20, 2025
d9e2c9b
fix(replication): add configuration parameter to enable calculation o…
mefcorvi Jul 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions replication/binlogsyncer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -861,6 +861,16 @@ func (b *BinlogSyncer) handleEventAndACK(s *BinlogStreamer, e *BinlogEvent, need
if e.Header.LogPos > 0 {
// Some events like FormatDescriptionEvent return 0, ignore.
b.nextPos.Pos = e.Header.LogPos
} else if b.cfg.Flavor == mysql.MariaDBFlavor && (e.Header.Flags&LOG_EVENT_ARTIFICIAL_F) == 0 && e.Header.LogPos == 0 {
// For MariaDB 11.4+, some events may have LogPos=0 but are still valid position updates
// if they are not artificial events (marked with LOG_EVENT_ARTIFICIAL_F flag).
// For such events, we calculate the next position dynamically.
calculatedPos := b.nextPos.Pos + e.Header.EventSize
e.Header.LogPos = calculatedPos
b.nextPos.Pos = calculatedPos
b.cfg.Logger.Debug("MariaDB event with LogPos=0 but not artificial, calculated position",
slog.String("eventType", e.Header.EventType.String()),
slog.Uint64("logPos", uint64(calculatedPos)))
}

// Handle event types to update positions and GTID sets
Expand Down
Loading