Skip to content

Cleaning up codebase (WIP) #722

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from
Draft

Cleaning up codebase (WIP) #722

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
aedb000
Define data types for base plugin properties
nmolham-godaddy Oct 10, 2024
429387a
Define data type hints for base plugin methods
nmolham-godaddy Oct 10, 2024
0b091ca
Release: v5.15.4
agibson-godaddy Feb 3, 2025
0e31cb3
Rebuild assets
agibson-godaddy Feb 3, 2025
5ab7889
Update autoload paths
agibson-godaddy Feb 3, 2025
3d41b0e
Merge branch 'release/5.15.4' into chore/code-cleanup
nmolham-godaddy Feb 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions tests/_support/plugins/gateway-test-plugin/includes/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,26 +46,26 @@ public function __construct() {
}


public function get_documentation_url() {

public function get_documentation_url() : ?string
{
return 'https://example.com';
}


public function get_settings_url( $plugin_id = null ) {

public function get_settings_url( string $plugin_id = null ) : string
{
return admin_url( 'admin.php?page=wc-settings' );
}


public function get_plugin_name() {

public function get_plugin_name() : string
{
return 'Framework Gateway Test Plugin';
}


protected function get_file() {

protected function get_file() : string
{
return __DIR__;
}

Expand Down
16 changes: 8 additions & 8 deletions tests/_support/plugins/test-plugin/includes/Plugin.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,26 +45,26 @@ public function __construct() {
}


public function get_documentation_url() {

public function get_documentation_url() : ?string
{
return 'https://example.com';
}


public function get_settings_url( $plugin_id = null ) {

public function get_settings_url( string $plugin_id = null ) : string
{
return admin_url( 'admin.php?page=wc-settings' );
}


public function get_plugin_name() {

public function get_plugin_name() : string
{
return 'Plugin Framework Test';
}


protected function get_file() {

protected function get_file() : string
{
return __DIR__;
}

Expand Down
Loading
Loading