Correctly set instance bindings on reload #1590
Merged
+16
−29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsnopek
added
bug
This was referenced Sep 17, 2024
|
Is this indefinitely blocked because there's no other reviewers? |
|
I wouldn't call it "indefinitely blocked" - it's "awaiting review" :-) |
paddy-exe
approved these changes
Oct 16, 2024
|
I just tested the PR on top of my personal project (by checking out your branch and recompiling). I was hoping it might solve godotengine/godot#96403, which I now thought might be a duplicate of #1589. Unfortunately, it didn't. I still get class load errors whenever the project is recompiled. Regarding the repro project linked in #1589, I was not able to build the project on top of it since it had a structure I was not familiar with. |
|
Cherry-picked for 4.3 in PR #1632 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In PR #1446, we forgot to make sure that instance bindings were being set when recreating an instance with a pre-existing owner (which is what happens on hot reload), leading to incomplete reload.
This fixes that, while also making the code more consistent with the approach used in #1446.
Fixes #1589