-
-
Notifications
You must be signed in to change notification settings - Fork 674
Files generated by SCons should depend on the build_profile
(if given)
#1795
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Files generated by SCons should depend on the build_profile
(if given)
#1795
Conversation
This does seem to fix the issue with godot_openxr_vendor's CI. We were having the issue on We'll keep testing it there for a bit and see if the issue manages to recur :-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the build_profile
affect how these files are built? I thought it only affects if they are built, in which case the dependency shouldn't be needed.
Yes. It'll omit methods that have argument or return value types that aren't included in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Makes sense to me. Implementation looks good to me, I'd probably do it the same way.
Just one thing that should probably be tested.
Over a couple of PRs that have made changes to the |
Let's give this one a try and see how it goes |
Cherry-picked for 4.4 in PR #1836 |
On godot_openxr_vendors, we've been having this problem with the SCons cache on CI, where if a PR adds something to the
build_profile.json
it'll still use outdated generated files from the cache.This change attempts to make it so that it'll rebuild the generated files if the
build_profile.json
changesI'm still not entirely sure this fixes the issue, because it's hard to test in the context of CI, but I'll see what I can do!And I'd also appreciate feedback from folks who are more experienced with build system stuff
UPDATE: I've managed to do some testing (see this comment), and it seems to be working