[GitHub CI] Fix source detection, added missing include .hpp and .inc to detection rules. #1796
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removed redundant .py detection.
dsnopek
added
bug
|
Thanks! This seems good to me. What needs to be done in order to take it out of draft? |
nothing. :) |
|
Cherry-picked for 4.4 in PR #1805 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was noticed in #1772 that after updating a header the CI was not triggered.
This was my fault when I made the detection rules.
This PR updates the rules to include the missing .hpp files.
I also double checked what other files may be valid to detect and found
include\godot_cpp\core\math.compat.incI removed redundant .py detection in scons, as it was already in the sources section which triggers both builds.