Skip to content

Take reference in Wrapped(const StringName &) #1834

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 21, 2025

Conversation

dsnopek
Copy link
Collaborator

@dsnopek dsnopek commented Aug 20, 2025

Fixes #1797

This avoids a copy!

The automated tests run fine, and since this is only used internally, I don't think it should cause any issues

@dsnopek dsnopek added this to the 4.x milestone Aug 20, 2025
@dsnopek dsnopek requested a review from a team as a code owner August 20, 2025 16:15
@dsnopek dsnopek added the bug This has been identified as a bug label Aug 20, 2025
Copy link
Member

@Ivorforce Ivorforce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine in all situations.

@dsnopek dsnopek merged commit 21b7342 into godotengine:master Aug 21, 2025
16 checks passed
@dsnopek
Copy link
Collaborator Author

dsnopek commented Aug 21, 2025

Cherry-picked for 4.4 in PR #1836

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug This has been identified as a bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Possibly missed reference symbol in Wrapped constructor
2 participants