Make mute game button style consistent #112204
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Isn't that on purpose? |
Member
Author
|
Is it explained somewhere? The only benefit I can think of is that it displays the slash in red... |
I personally think this shape would be better than just crossing it out. I do like the new colors though. |
Member
|
Creating a new icon is out of scope for this PR, the current icon is also far more readable IMO, it's far easier to miss the difference between the lines and the cross compared with a large line crossing it out |
Contributor
|
It seems like it was discussed in RC, but it is intentional #99555 (comment) |
Member
Author
|
Closing as this PR seems controversial and is now containing conflicts with the current master. I no longer wish to maintain this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the game view, the mute game button is not styled the same as other toggles.
This PR makes it consistent: