Skip to content

Conversation

@Repiteo
Copy link
Contributor

@Repiteo Repiteo commented Oct 30, 2025

Revamps the Variant comparison operators to:

  • Utilize all comparison operations, with < and == as the baseline.
  • Add deleted template comparison operators behind STRICT_CHECKS macros

In practice, this makes all Variant comparison operations entirely self-contained, necessitating they be called explicitly. We already had to do this with certain ambiguous types (arithmetic types most obviously), so this is just enforcing that for all other types. It also helps showcase some areas with questionable Variant arguments/returns, that were otherwise being quietly converted. Keeping it behind the STRICT_CHECKS macro means that we aren't breaking compatibility out of the gate, so modules/extensions can gradually adopt this convention.

@Repiteo Repiteo added this to the 4.x milestone Oct 30, 2025
@Repiteo Repiteo requested review from a team as code owners October 30, 2025 21:49
@Repiteo Repiteo requested review from a team as code owners October 30, 2025 21:49
@Repiteo Repiteo removed request for a team October 30, 2025 21:49
@Repiteo Repiteo removed request for a team October 30, 2025 21:49
@Mickeon Mickeon requested a review from Ivorforce October 31, 2025 18:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant