Core: Delete implicit Variant comparison by default
#112224
Open
+197
−191
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revamps the
Variantcomparison operators to:<and==as the baseline.STRICT_CHECKSmacrosIn practice, this makes all Variant comparison operations entirely self-contained, necessitating they be called explicitly. We already had to do this with certain ambiguous types (arithmetic types most obviously), so this is just enforcing that for all other types. It also helps showcase some areas with questionable
Variantarguments/returns, that were otherwise being quietly converted. Keeping it behind theSTRICT_CHECKSmacro means that we aren't breaking compatibility out of the gate, so modules/extensions can gradually adopt this convention.