Skip to content

Conversation

@Giganzo
Copy link
Contributor

@Giganzo Giganzo commented Oct 31, 2025

Fixes: #112232

Before:

Screenshot_20251031_135805

After:

Screencast_20251031_132521.webm

This change has minimal effect on the classic theme

4.6.dev2:

Image

After:

Image

@Giganzo Giganzo requested a review from a team as a code owner October 31, 2025 13:01
@AThousandShips AThousandShips added this to the 4.6 milestone Oct 31, 2025
@Mickeon
Copy link
Member

Mickeon commented Oct 31, 2025

While I do approve of this PR because it's just as it was before, would it be completely weird and inconsistent to ask for these kinds of buttons to feature a more prominent background, but not brighter than the Inspector's itself?

@CardboardCarl
Copy link
Contributor

CardboardCarl commented Nov 1, 2025

While I do approve of this PR because it's just as it was before, would it be completely weird and inconsistent to ask for these kinds of buttons to feature a more prominent background, but not brighter than the Inspector's itself?

@Mickeon I think that might be better off as its own ticket; I'm concerned adding it might muddy the intent of this PR too much.

If I'm following correctly, the purpose of this PR was just to change the buttons from the "primary" style to the "flat" style. It seems they've been primary buttons this whole time when they should've been flat to begin with in order to match the design.

@akien-mga akien-mga merged commit cd7b57e into godotengine:master Nov 1, 2025
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@Giganzo Giganzo deleted the resource-picker-buttons branch November 1, 2025 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Buttons in modern styled themes draw too much attention

7 participants