Skip to content

Fix discrepancy in int handling between JSON::stringify and JSON::parse_string #112256

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+19 −5
Open

Fix discrepancy in int handling between JSON::stringify and JSON::parse_string #112256

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
deda069
Improve number parsing in JSON handling
Chkoupinator Oct 31, 2025
375c6d0
Merge branch 'godotengine:master' into patch-1
Chkoupinator Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 19 additions & 5 deletions core/io/json.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -384,11 +384,25 @@ Error JSON::_get_token(const char32_t *p_str, int &index, int p_len, Token &r_to

if (p_str[index] == '-' || is_digit(p_str[index])) {
//a number
const char32_t *rptr;
double number = String::to_float(&p_str[index], &rptr);
index += (rptr - &p_str[index]);
r_token.type = TK_NUMBER;
r_token.value = number;
int sub_index = index + 1;
while (is_digit(p_str[sub_index])) {
sub_index++;
}

if (p_str[sub_index] == 'e' || p_str[sub_index] == 'E' || p_str[sub_index] == '.') {
// float detected
const char32_t *rptr;
const double number = String::to_float(&p_str[index], &rptr);
index += (rptr - &p_str[index]);
r_token.type = TK_NUMBER;
r_token.value = number;
} else {
// int detected
const int64_t number = String::to_int(&p_str[index], sub_index - index);
index = sub_index;
r_token.type = TK_NUMBER;
r_token.value = number;
}
return OK;

} else if (is_ascii_alphabet_char(p_str[index])) {
Expand Down
Loading