Skip to content

Migrate spansql to memefish #1287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Migrate spansql to memefish #1287

wants to merge 1 commit into from

Conversation

fedevilensky
Copy link

Refactor spanner.go and spanner_test.go to utilize github.com/cloudspannerecosystem/memefish, instead of spansql, for SQL statement parsing and clean up expected outputs in tests.

This has two main advantages:

  1. github.com/cloudspannerecosystem/memefish is actively maintained
  2. This will allow for both DDL and DML statements when running migrations

Refactor spanner.go and spanner_test.go to utilize memefish, instead …
cdaa02d 
…of spansql, for SQL statement parsing and clean up expected outputs in tests.
@coveralls
Copy link

Coverage Status

coverage: 56.314%. remained the same
when pulling cdaa02d on fedevilensky:master
into 2788339 on golang-migrate:master.

@apstndb
Copy link

apstndb commented Jun 17, 2025 •
edited
Loading

Related

I have recommended to use memefish lexer.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fedevilensky @coveralls @apstndb