-
Notifications
You must be signed in to change notification settings - Fork 18.3k
cmd/compile: prefer base.Fatalf to panic in dwarfgen #74616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmd/compile: prefer base.Fatalf to panic in dwarfgen #74616
Conversation
Updates a few spots which call `panic` to instead call `base.Fatalf`.
This PR (HEAD: b3839bb) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/688035. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Derek Parker: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Keith Randall: Patch Set 1: Code-Review+2 Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-07-15T15:37:52Z","revision":"83239b5e1d0a7797bbdf1dadf46b9c27433c6987"} Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Keith Randall: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Keith Randall: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/688035. |
Updates a few spots which call `panic` to instead call `base.Fatalf`. Change-Id: I30b73c7994caa647245b0e253f20e0b88185e644 GitHub-Last-Rev: b3839bb GitHub-Pull-Request: #74616 Reviewed-on: https://go-review.googlesource.com/c/go/+/688035 Reviewed-by: Keith Randall <[email protected]> Reviewed-by: Michael Knyszek <[email protected]> Reviewed-by: Keith Randall <[email protected]> Auto-Submit: Michael Knyszek <[email protected]> LUCI-TryBot-Result: Go LUCI <[email protected]>
This PR is being closed because golang.org/cl/688035 has been merged. |
Updates a few spots which call
panic
to instead callbase.Fatalf
.