-
Notifications
You must be signed in to change notification settings - Fork 18.5k
go/token: replace map with array for looking up keywords #76622
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
This PR (HEAD: 6e80fe2) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725320. Important tips:
|
array access has considerable less overhead than map access thus yielding benefits in performance and package initialization.
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Patricio Whittingslow: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Patricio Whittingslow: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Jorropo: Patch Set 2: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-11-29T23:06:25Z","revision":"6e27e7d0aa01c7ac0833fbb205c40367075e7eb4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Jorropo: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Go LUCI: Patch Set 2: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Ingo Oeser: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
Message from Vann Te: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
|
This PR (HEAD: 0873615) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/725320. Important tips:
|
|
Message from Patricio Whittingslow: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/725320. |
array access has considerable less overhead than map access
thus yielding benefits in performance and package initialization
cost.