Skip to content

design: add design/74609-goroutine-leak-detection-gc.md #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 6 commits into from
Closed

design: add design/74609-goroutine-leak-detection-gc.md #58

wants to merge 6 commits into from

Conversation

VladSaiocUber
Copy link
Contributor

@VladSaiocUber VladSaiocUber commented Jul 22, 2025 •
edited
Loading

For golang/go#74609

Changes at CL 688335

@gopherbot
Copy link

This PR (HEAD: f2a5144) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/689555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Gopher Robot:

Patch Set 1:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@VladSaiocUber VladSaiocUber changed the title Goroutine leak detection via garbage collection design doc. Goroutine leak detection via garbage collection design doc Jul 23, 2025
@gopherbot
Copy link

This PR (HEAD: 0424f7a) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/689555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

This PR (HEAD: 02b4d79) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/689555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Georgian-Vlad Saioc:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Michael Knyszek:

Patch Set 4: Code-Review+2

(12 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Michael Knyszek:

Patch Set 4:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@VladSaiocUber VladSaiocUber changed the title Goroutine leak detection via garbage collection design doc design: add design/74609-goroutine-leak-detection-gc.md Sep 8, 2025
@gopherbot
Copy link

Message from t hepudds:

Patch Set 6:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from t hepudds:

Patch Set 6:

(1 comment)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Georgian-Vlad Saioc:

Patch Set 8:

(14 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@VladSaioc VladSaioc mentioned this pull request Sep 8, 2025
Open
@gopherbot
Copy link

Message from t hepudds:

Patch Set 8:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

This PR (HEAD: 49564e8) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/proposal/+/689555.

Important tips:

  • Don't comment on this PR. All discussion takes place in Gerrit.
  • You need a Gmail or other Google account to log in to Gerrit.
  • To change your code in response to feedback:
    • Push a new commit to the branch used by your GitHub PR.
    • A new "patch set" will then appear in Gerrit.
    • Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
    • Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
    • Multiple commits in the PR will be squashed by GerritBot.
  • The title and description of the GitHub PR are used to construct the final commit message.
    • Edit these as needed via the GitHub web interface (not via Gerrit or git).
    • You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
  • See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

@gopherbot
Copy link

Message from Georgian-Vlad Saioc:

Patch Set 9:

(2 comments)

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

@gopherbot
Copy link

Message from Michael Knyszek:

Patch Set 9: Code-Review+2

Please don’t reply on this GitHub thread. Visit golang.org/cl/689555.
After addressing review feedback, remember to publish your drafts!

gopherbot pushed a commit that referenced this pull request Sep 8, 2025
@VladSaiocUber @mknyszek
design: add design/74609-goroutine-leak-detection-gc.md
f6e2e6b 
For golang/go#74609

Changes at CL 688335

Change-Id: I605c0d4aa88cd44f42300ebe476496744d93f9ce
GitHub-Last-Rev: 49564e8
GitHub-Pull-Request: #58
Reviewed-on: https://go-review.googlesource.com/c/proposal/+/689555
Reviewed-by: Michael Knyszek <[email protected]>
Reviewed-by: Michael Pratt <[email protected]>
@gopherbot
Copy link

This PR is being closed because golang.org/cl/689555 has been merged.

@gopherbot gopherbot closed this Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@VladSaiocUber @gopherbot