Skip to content

Conversation

MarkDaoust
Copy link
Contributor

@MarkDaoust MarkDaoust commented May 30, 2024

Add a starter script for testing notebooks.

based on google3/devsite/tools/tensorflow/kokoro/tf_ecosystem/executor.py

This gets most notebooks passing, we can use it as a base to setup presubmits.

Some notebooks are still failing:

  • /Users/markdaoust/Projects/cookbook/examples/Voice_memos.ipynb - api installs
  • /Users/markdaoust/Projects/cookbook/examples/Agents_Function_Calling_Barista_Bot.ipynb - user input
  • /Users/markdaoust/Projects/cookbook/quickstarts/PDF_Files.ipynb - needs to install pdf tools
  • /Users/markdaoust/Projects/cookbook/quickstarts/Authentication_with_OAuth.ipynb - oauth + a problem with list models?
  • /Users/markdaoust/Projects/cookbook/quickstarts/Tuning.ipynb - oauth + a problem with list models?

See also: google/generative-ai-docs#445

Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@github-actions github-actions bot added status:awaiting review PR awaiting review from a maintainer component:examples Issues/PR referencing examples folder component:quickstarts Issues/PR referencing quickstarts folder labels May 30, 2024
@MarkDaoust MarkDaoust marked this pull request as draft May 31, 2024 00:03
@MarkDaoust
Copy link
Contributor Author

It's still pretty rough, but it gets the notebooks run.

Some notebooks only run with api_key, others only with oauth. We'll need to fix this.

We should probably look at using colab's docker:

https://twitter.com/GoogleColab/status/1663594080436375558

Then run in GH actions or kokoro.

https://docs.github.com/en/actions/creating-actions/creating-a-docker-container-action

@MarkDaoust MarkDaoust marked this pull request as ready for review June 5, 2024 17:26
@Giom-V
Copy link
Collaborator

Giom-V commented Mar 24, 2025

I think we should close this PR as it's quite old and some much has changed since then...

@Giom-V Giom-V self-assigned this Mar 25, 2025
@Giom-V Giom-V marked this pull request as draft April 22, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component:examples Issues/PR referencing examples folder component:quickstarts Issues/PR referencing quickstarts folder status:awaiting review PR awaiting review from a maintainer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants