Conversation
- Add `ListSourcesOptions` to `packages/core/src/types.ts`. - Update `SourceManager` interface to accept `ListSourcesOptions`. - Update `SourceManagerImpl.list` to use `filter` and `pageSize` from options. - Add tests for source filtering and pagination in `packages/core/tests/sources.test.ts`. Fixes #90 Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
davideast
deleted the
jules-core-source-filtering-90-13863415910140211699
branch
1 participant
Fixes #90
This PR updates the
SourceManagerin@google/jules-sdkto support server-side filtering and custom page sizes when listing sources. This aligns the SDK with the v1alpha API capabilities.Changes:
packages/core/src/types.tsto defineListSourcesOptionsand updateSourceManagercall signature.packages/core/src/sources.tsto implement the filtering logic inSourceManagerImpl.list.packages/core/tests/sources.test.tswith new test cases for filtering and pagination.PR created automatically by Jules for task 13863415910140211699 started by @davideast