Skip to content

Fix: Remove source/activities from RestSessionResource#93

Open
davideast wants to merge 1 commit intomainfrom
fix-session-resource-cleanup-13533407257037680422
Open

Fix: Remove source/activities from RestSessionResource#93
davideast wants to merge 1 commit intomainfrom
fix-session-resource-cleanup-13533407257037680422

Conversation

@davideast
Copy link
Collaborator

This PR aligns the RestSessionResource interface with the v1alpha API schema by removing source, activities, and generatedFiles fields.

Changes:

  • Modified packages/core/src/types.ts: Removed the fields and added [key: string]: unknown to support existing tests that inject these fields in mock objects.
  • Modified packages/core/src/mappers.ts: Updated mapRestSessionToSdkSession to explicitly set source, activities, and generatedFiles to undefined and removed mapping logic for these fields.
  • Modified packages/core/tests/mappers.test.ts: Added a verification test case to ensure these fields are correctly set to undefined.

This ensures the SDK correctly handles the sparse Session resource returned by the API.


PR created automatically by Jules for task 13533407257037680422 started by @davideast

Fixes #88. Removed `source`, `activities`, and `generatedFiles` from `RestSessionResource` interface and updated mappers to handle their removal. Added index signature to `RestSessionResource` for backward compatibility with existing tests.

Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
@google-labs-jules
Copy link
Contributor

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant