Add a new fingerprinting method for XNNPack weight cache. #8923
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
copybara-service
bot
force-pushed
the
test_809079455
branch
3 times, most recently
from
12de7ae to
f2a22c7
Compare
copybara-service
bot
changed the title
copybara-service
bot
force-pushed
the
test_809079455
branch
9 times, most recently
from
2e89f5c to
9202c02
Compare
copybara-service
bot
force-pushed
the
test_809079455
branch
7 times, most recently
from
8f54a80 to
f73507b
Compare
copybara-service
bot
force-pushed
the
test_809079455
branch
6 times, most recently
from
45d9f62 to
75c2821
Compare
Warning: this new fingerprinting method is currently experimental. Every operation in XNNPack that uses the weight cache should implement a corresponding fingerprinting function. The goal of that fingerprint is to check whether the pre-computation (packing) that takes place for this op has changed and if a previous weight cache can be reused directly or not. The expected way for this to work is that a fingerprint function would assume a predetermined set of constant inputs passed to the create function and would then hash the resulting cache buffer. The `xnn_weights_cache_look_up_key` has a new field that holds the fingerprint identifier. It is set by kernel setup functions when they try to do cache look-ups. PiperOrigin-RevId: 809079455
copybara-service
bot
force-pushed
the
test_809079455
branch
from
75c2821 to
0f1be92
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new fingerprinting method for XNNPack weight cache.
Warning: this new fingerprinting method is currently experimental.
Every operation in XNNPack that uses the weight cache should implement a
corresponding fingerprinting function. The goal of that fingerprint is to check
whether the pre-computation (packing) that takes place for this op has changed
and if a previous weight cache can be reused directly or not.
The expected way for this to work is that a fingerprint function would assume a
predetermined set of constant inputs passed to the create function and would
then hash the resulting cache buffer.
The
xnn_weights_cache_look_up_keyhas a new field that holds the fingerprintidentifier. It is set by kernel setup functions when they try to do cache
look-ups.