Skip to content

fix: allow concurrent write to layout index #2175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cjc7373 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: allow concurrent write to layout index #2175

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions pkg/v1/layout/write.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,9 @@ var layoutFile = `{
// renameMutex guards os.Rename calls in AppendImage on Windows only.
var renameMutex sync.Mutex

// layoutIndexMutex guards the write to index.json
var layoutIndexMutex sync.Mutex

// AppendImage writes a v1.Image to the Path and updates
// the index.json to reference it.
func (l Path) AppendImage(img v1.Image, options ...Option) error {
Expand Down Expand Up @@ -84,6 +87,9 @@ func (l Path) AppendIndex(ii v1.ImageIndex, options ...Option) error {

// AppendDescriptor adds a descriptor to the index.json of the Path.
func (l Path) AppendDescriptor(desc v1.Descriptor) error {
layoutIndexMutex.Lock()
defer layoutIndexMutex.Unlock()

ii, err := l.ImageIndex()
if err != nil {
return err
Expand Down