Skip to content

Write pidfile atomically #11983

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 15, 2025
Merged

Conversation

stepancheg
Copy link
Contributor

Fixes #11851. Alternative to #11861.

@stepancheg
Copy link
Contributor Author

Took me a while to find a linux devbox.

Copy link
Collaborator

@EtiennePerot EtiennePerot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, just code style comments.

@stepancheg
Copy link
Contributor Author

Done.

@stepancheg stepancheg force-pushed the pid-file-2 branch 2 times, most recently from 3b58748 to 91206db Compare August 13, 2025 07:17
Copy link
Collaborator

@EtiennePerot EtiennePerot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is failing Google-internal presubmit checks due to the lack of copyright header on pidfile.go and pidfile_test.go; please copy/paste it from other Go files (just with the year to 2025).

copybara-service bot pushed a commit that referenced this pull request Aug 14, 2025
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
copybara-service bot pushed a commit that referenced this pull request Aug 14, 2025
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
copybara-service bot pushed a commit that referenced this pull request Aug 14, 2025
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
copybara-service bot pushed a commit that referenced this pull request Aug 15, 2025
Fixes #11851. Alternative to #11861.

FUTURE_COPYBARA_INTEGRATE_REVIEW=#11983 from stepancheg:pid-file-2 e31a03d
PiperOrigin-RevId: 794437043
@copybara-service copybara-service bot merged commit 5077500 into google:master Aug 15, 2025
5 checks passed
@EtiennePerot
Copy link
Collaborator

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exec -internal-pid-file cannot be used reliably
2 participants