Rename WARN* functions to BugTraceback*, and optimize them for inlining. #11994
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl789915634
branch
2 times, most recently
from
79a462f to
84aa92b
Compare
The rename is todo with following a more Go-style naming convention. To this end, the "default" BugTraceback will be the one that takes a single error parameter. The simple "cond" variant will likely not be widely used and has been removed. As to inlining the BugTraceback(err) variant seems to require a hack from pkg/sync/gate_unsafe.go:Enter where there is a noinline helper, so as to make it check err == nil before making an expensive err.Error() call. PiperOrigin-RevId: 791443090
copybara-service
bot
force-pushed
the
test/cl789915634
branch
from
84aa92b to
2099bc1
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename WARN* functions to BugTraceback*, and optimize them for inlining.
The rename is todo with following a more Go-style naming convention. To this
end, the "default" BugTraceback will be the one that takes a single error
parameter. The simple "cond" variant will likely not be widely used and has
been removed.
As to inlining the BugTraceback(err) variant seems to require a hack from
pkg/sync/gate_unsafe.go:Enter where there is a noinline helper, so as to make
it check err == nil before making an expensive err.Error() call.