Allow IP_(ADD|REMOVE)_MEMBERSHIP on AF_INET6 sockets #12142
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![copybara-service[bot]](https://avatars.githubusercontent.com/in/44061?s=60&v=4){kind=small}
copybara-service
bot
force-pushed
the
test/cl807959283
branch
from
161bbac to
776cc3f
Compare
copybara-service
bot
changed the title
Just like Linux does. The new test `AddV4MembershipToV6Socket` passes only if there is a routing table entry to resolve the ipv4 multicast address, and that is easiest to setup via a "external networking" test. Now it turns out that the ipv6 "external networking" test did not actually have a second non-loopback (external) interface, so I've added that. PiperOrigin-RevId: 807959283
copybara-service
bot
force-pushed
the
test/cl807959283
branch
from
776cc3f to
f4d6e83
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow IP_(ADD|REMOVE)_MEMBERSHIP on AF_INET6 sockets
Just like Linux does.
The new test
AddV4MembershipToV6Socketpasses only if there is a routingtable entry to resolve the ipv4 multicast address, and that is easiest to setup
via a "external networking" test. Now it turns out that the ipv6 "external
networking" test did not actually have a second non-loopback (external)
interface, so I've added that.